Closed Bug 994024 Opened 6 years ago Closed 6 years ago

Add more assertions to the client side gfx ipdl glue code

Categories

(Core :: Graphics: Layers, defect)

x86_64
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(3 files)

I have seen some crashes happening where we seem to be placing null ipdl actors in ipc messages in ShadowLayers.cpp. The stack traces for these crashes are not the most helpful because the messages are processed at the end of the transaction.
Let's add assertions in ShadowLayers.cpp so that we can catch these mistakes when they are made instead of at the end of the transaction.
Attachment #8403952 - Flags: review?(bjacob)
The assertions are hit in some tests where we try to allocate 10000x10000 canvases. In this kind of situation we ended up with a TextureClient that we failed to serialize, although we kept it around. There is code in ImageClient and CanvasClient that assume that after a certain point, if we have a FrontBuffer, it has successfully been serialized. This patch makes sure we can actually make that assumption.
Attachment #8403994 - Flags: review?(bjacob)
Attachment #8403994 - Flags: review?(bjacob) → review+
Attachment #8403952 - Flags: review?(bjacob) → review+
Attachment #8403931 - Flags: review?(bjacob) → review+
You need to log in before you can comment on or make changes to this bug.