994163 - TraceLogger doesn't compile with --disable-threadsafe

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Not sure whether we want --enable-threadsafe to be a dependency of --enable-trace-logger or not, but there is clearly something we need to do here.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: tracelogging-fix-threadsafe

Correct. Tracelogger should be able to work with --disable-threadsafe

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8404509 [details] [diff] [review]
tracelogging-fix-threadsafe

Review of attachment 8404509 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!

::: js/src/vm/TraceLogging.cpp
@@ +797,5 @@
>      return mainThread->traceLogger;
>  }
>  
>  TraceLogger *
> +js::TraceLoggerForThread()

The name is not really clear anymore, now that there's no argument anymore. How about renaming it TraceLoggerForCurrentThread() or something better you'd have in mind?

::: js/src/vm/TraceLogging.h
@@ +389,5 @@
>      typedef HashMap<PRThread *,
>                      TraceLogger *,
>                      PointerHasher<PRThread *, 3>,
>                      SystemAllocPolicy> ThreadLoggerHashMap;
> +#endif

Could you suffix these #endif with // JS_THREADSAFE, so that we don't get confused with which ifdef we're closing?

@@ +400,2 @@
>      ThreadLoggerHashMap threadLoggers;
> +#endif

ditto

@@ +418,2 @@
>      TraceLogger *forThread(PRThread *thread);
> +#endif

ditto

Comment 3

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2adbe2a41c0

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f2adbe2a41c0