994263 - Removing GC'd nodes in the Web Audio Editor frontend

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

For AudioNode#disconnect() cases, not garbage collecting cases.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Correcting myself, this is for when

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Correcting myself, this is for when a node gets GC'd as there's no way to explicitly delete nodes, and disconnected nodes should still remain in the params and graph view.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 994263-hide-destroy-nodes-in-wae-front-end.patch (WIP)

WIP patch, dependent on back end server events (bug 980506)

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=e936584e35c9

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 994263-hide-destroy-nodes-in-wae-front-end.patch

During the tests, waits a few seconds for GC, even after calling the force cycle collection/GC -- wonder if this will be an issue.

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Try failed, resubmiting with changes: https://tbpl.mozilla.org/?tree=Try&rev=d361ec438745

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 994263-hide-destroy-nodes-in-wae-front-end.patch

Comment 9

[Victor Porof [:vporof][:vp]]

Comment on attachment 8444855 [details] [diff] [review]
994263-hide-destroy-nodes-in-wae-front-end.patch

Review of attachment 8444855 [details] [diff] [review]:
-----------------------------------------------------------------

Clean as always.

Comment 10

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 994263-hide-destroy-nodes-in-wae-front-end.patch

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b043afd9261f

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b043afd9261f