994298 - Preview not working for more complicated makes in Thimble

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Kat Braybrooke [:codekat]]

Attachment: Screen Shot 2014-04-09 at 1.21.51 PM.png

Have been getting lots of feedback lately that on various starter resources and makes that integrate more advanced features (such as this one ), the "preview" window isn't working. 

Example #1: Presentation https://dajbelshaw.makes.org/thimble/LTE1NTkxMDE0NA==/oppi-festival-2014 and its blank remix window: https://thimble.webmaker.org/project/46582/remix

Example #2: A starter resource, Webmaker Planet: https://chadsansing.makes.org/thimble/webmaker-planet Works fine in final view, but preview similarly blank: https://thimble.webmaker.org/project/42998/remix

Have attached screenshot of what the blank "preview" pane looks like on my browser. Woot :)

Comment 1

[Chris DeCairos (:cade)]

This looks like the same issue as Bug 991788 - the preview pane fails on a load if there's a CSS error.

Comment 2

[Kat Braybrooke [:codekat]]

Chris, this is happening also for makes that *don't* have css errors that I can see -- or at least they're not called out in the code. 

Worth looking into separately as a result. See Example 1, which doesn't call out any errors.

Comment 3

[Chris DeCairos (:cade)]

I dug into this a bit more.

If you load the project in a browser that is not logged into Webmaker, it will fail to load.

This looks directly related to the https proxy, as once you change all urls to "https" it loads the preview.

Comment 4

[Kat Braybrooke [:codekat]]

Chris, hmm. This poses a problem, given that the Starter Resources currently on https://webmaker.org/resources go directly to "remix" -- so, folks who don't already have Webmaker accounts will see blank pages when they check a new resource out?

Comment 5

[Pomax]

The proxy's supposed to generate regular mixed-content errors when a user isn't logged in, so something more is going on here. I do see some errors in the console when I get a blank view when I try to edit some text (in the gutter-placement code, which is where things would go wrong when thimble tries to attach error notices) so some more debugging is required.

Comment 6

[Pomax]

a quick debug test to disable the error code reveals that the proxy indeed won't kick in and will make thimble place an error on the first http:// resource. This happens to be a google webfont, which can be trivially fixed by giving it an https:// instead of http:// link. The same goes for all the github.io links, which work on https as well as http, so this make can be fixed really easily by simply making all those http resources https resources instead with the addition of a few 's'es.

Comment 7

[Brett Gaylor [:brett]]

Hmmm.  This works for makes that we control, Pomax.  But the problem is going to persist for those that have been created by others, correct?

Comment 8

[Pomax]

definitely. If you're not logged in but you have a make with http:// resources, then (if we fix the actual bug in the error placement code here) you'll get errors telling you that you need to log in before those resources can be loaded.

For security reasons, we cannot run an open proxy, so there is virtually no way for use to load up working links in the previewer without first getting people to log in.

Comment 9

[Brett Gaylor [:brett]]

Here are the following URLs that need to have their external resources loaded from https rather than http

https://thimble.webmaker.org/project/21788/remix
https://thimble.webmaker.org/project/17857/remix
https://thimble.webmaker.org/project/14660/remix
https://thimble.webmaker.org/project/42998/remix

Comment 10

[Kat Braybrooke [:codekat]]

Reopening this bug for the moment so I can keep better track of its (important!) conversation :) Can someone give me access to the S3 bin or another http to https converter so we can make these 4 makes work for the not-logged-in folk?

Comment 11

[Kat Braybrooke [:codekat]]

ok. s3 bin activated. working to get those 4 updated, since they're not all made by me. 

make 1: artychan has to edit; she made tutorial version i'm using
make 2: will ask fuzzy to edit
make 3: i'm creator account for that; is now edited.
make 4: will ask chad to edit. 

thanks - and if you find more not working, let me know!

Comment 12

[Robert Friedman [:omnignorant]]

Hey Guys, not sure if I understand this thread, but I think I found this bug in this make:
https://thimble.webmaker.org/project/42998/remix

Doesn't seem to matter whether I am logged in or not. There's an error with some "behavior" CSS property, but it doesn't seem to resolve the bug if I comment it out of the code.

Comment 13

[Pomax]

that's a normal CSS error and whoever owns that make will have to fix it.

Comment 14

[Kat Braybrooke [:codekat]]

Hey Robert. Chad is working on this, but needs some help with the code, as does Doug for his presentation make. 

Pomax, would you be the right person to direct em to? I couldn't figure it out, either!

Comment 15

[Pomax]

the error I saw as a css property "behaviour" pointing at "PIE.htc" on line 35. I have no idea what the intention was, there, but it's definitely not legal CSS. There's also a lot of "align: ..." that should be text-align, fixing all that, there's then also an unclosed CSS block so my recommendation is to just literally open it in thimble, and scroll through it, resolving each error.