994423 - please add CORS for mini-manifest URL's

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P3)

Description

[Bill Walker [:bwalker] [@wfwalker]]

Please add CORS headers for mini-manifest URL's, so that after retrieving other app information using the Marketplace API with CORS, I can also retrieve the mini-manifest with CORS.

Example: "https://marketplace.firefox.com/app/0213a06f-2efb-4d4f-aab7-04dd267d4168/manifest.webapp"

Comment 1

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/a650f722

Comment 2

[Madalin Cotetiu]

Please add STR here or mark it with [qa-] if no QA is needed.

Comment 3

[Rob Hudson [:robhudson]]

To verify visit the mini-manifest URL using something like curl and verify it has the appropriate CORS headers. (The mini-manifest URL can be found by visiting a packaged app page and inspecting the install button.)

Comment 4

[Madalin Cotetiu]

I have used this packaged app https://marketplace-dev.allizom.org/app/approvetest519-5?src=all-reviewed
and obtained this mini-manifest url: https://marketplace-dev.allizom.org/app/8efeacec-1d41-4378-9071-69ab6fce5ebd/manifest.webapp

I see there are 3 CORS headers: http://screencast.com/t/65TcDhr1

Anything else we should verify regarding this issue?

Comment 5

[Rob Hudson [:robhudson]]

(In reply to Madalin Cotetiu from comment #4)
> I have used this packaged app
> https://marketplace-dev.allizom.org/app/approvetest519-5?src=all-reviewed
> and obtained this mini-manifest url:
> https://marketplace-dev.allizom.org/app/8efeacec-1d41-4378-9071-69ab6fce5ebd/
> manifest.webapp
> 
> I see there are 3 CORS headers: http://screencast.com/t/65TcDhr1
> 
> Anything else we should verify regarding this issue?

No, I think that does it.

Comment 6

[Madalin Cotetiu]

(In reply to Rob Hudson [:robhudson] from comment #5)
> (In reply to Madalin Cotetiu from comment #4)
> > I have used this packaged app
> > https://marketplace-dev.allizom.org/app/approvetest519-5?src=all-reviewed
> > and obtained this mini-manifest url:
> > https://marketplace-dev.allizom.org/app/8efeacec-1d41-4378-9071-69ab6fce5ebd/
> > manifest.webapp
> > 
> > I see there are 3 CORS headers: http://screencast.com/t/65TcDhr1
> > 
> > Anything else we should verify regarding this issue?
> 
> No, I think that does it.

Thanks Rob!
Verified as fixed in marketplace-dev.allizom.org on FF33 (Win7)
Closing.