Closed Bug 994448 Opened 6 years ago Closed 6 years ago

test_contacts_blobs.html doesn't actually test the values gotten from the Contacts API

Categories

(Core Graveyard :: DOM: Contacts, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: reuben, Assigned: u454397)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
We're checking createResult1 and properties1 - both local to the test, never go through the Contacts API.
Attachment #8404392 - Flags: review?(anygregor)
Comment on attachment 8404392 [details] [diff] [review]
Patch

Review of attachment 8404392 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/tests/test_contacts_blobs.html
@@ +97,5 @@
> +     "blob1 is an instance of nsIDOMBlob");
> +  is(blob2 instanceof SpecialPowers.Ci.nsIDOMBlob, true,
> +     "blob2 is an instance of nsIDOMBlob");
> +  is(blob1 instanceof SpecialPowers.Ci.nsIDOMFile, false,
> +     "blob1 is an instance of nsIDOMFile");

is not

@@ +99,5 @@
> +     "blob2 is an instance of nsIDOMBlob");
> +  is(blob1 instanceof SpecialPowers.Ci.nsIDOMFile, false,
> +     "blob1 is an instance of nsIDOMFile");
> +  is(blob2 instanceof SpecialPowers.Ci.nsIDOMFile, false,
> +     "blob2 is an instance of nsIDOMFile");

is not
Attachment #8404392 - Flags: review?(anygregor) → review+
https://hg.mozilla.org/mozilla-central/rev/f69f2fb11938
Assignee: nobody → reuben.morais
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.