994453 - Create some utility methods for JS-wrapping C++ values

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Basically factoring out the stuff in Promise.h right now.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Factor out the to-JS conversions from Promise.h into mozilla::dom::ToJS methods. from moving the methods, I made the following changes:

1)  Renamed them to ToJS.
2)  Inlined the boolean overload.
3)  Added overloads that take integer types.
4)  Changed the order of the aCx and aArgument arguments so aCx comes first.
5)  Renamed "abv" to "obj" in the typed array overload.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Use the new ToJS methods so we have an example.

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8404401 [details] [diff] [review]
part 1.  Factor out the to-JS conversions from Promise.h into mozilla::dom::ToJS methods.   from moving the methods, I made the following changes:

Review of attachment 8404401 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that (which we also discussed on IRC)

::: dom/bindings/ToJS.h
@@ +4,5 @@
> + * License, v. 2.0. If a copy of the MPL was not distributed with this file,
> + * You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#ifndef mozilla_dom_ToJS_h
> +#define mozilla_dom_ToJS_h

It seems like it would be a lot clearer to call this stuff "ToJSValue". Is there any reason not to do that?

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4420ba8e8b32
https://hg.mozilla.org/integration/mozilla-inbound/rev/45d3f9cfb0df

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4420ba8e8b32
https://hg.mozilla.org/mozilla-central/rev/45d3f9cfb0df