Closed Bug 994485 Opened 6 years ago Closed 6 years ago

make desktop client pull and build without needing to hand-hack other repos & symlinks

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla33
Blocking Flags:
backlog mlp+

People

(Reporter: dmose, Assigned: standard8)

References

Details

(Whiteboard: [est:4d, p=4][coordination])

User Story

Things to consider:

- When moving loop-client to m-c, is it easy to get l10n for the web part "free"?
- What's the shipping model for the web pages, does this force loop-client to be separate?

Attachments

(5 files, 2 obsolete files)

Once we've gotten all the necessary signoffs to make the shared tests and code in loop-client public, we'll need to make the desktop build with loop enabled "Just Work" before we can actually have a candidate for merging into mozilla-central proper.

At the very least, this means that anyone using hg should be able to pull, build, and submit patches to the desktop client without having to go through any more process than they do today.
Depends on: 976279
Blocks: 994483
Whiteboard: [est:?]
Probably 1 day of work, but 3 days of discussion.
Whiteboard: [est:?] → [est:4d][coordination]
Priority: -- → P3
backlog: --- → mlp+
Depends on: 995355
Blocks: 995355
No longer depends on: 995355
After discussion with Mark, and doing a bunch of think about localization, testing, and deployment questions, we've come to the conclusion that we're going to want to list out and prioritize the various constraints we're trying to satisfy with the new layout.  Mark said he was start an Etherpad on this tomorrow...
Blocks: 1000085
Whiteboard: [est:4d][coordination] → [est:4d, p=4][coordination]
Target Milestone: --- → mozilla32
Priority: P3 → P1
This is currently blocked by 3rd party negotiations and agreements.  When they are resolved, this work can move forward.  Dan had been driving this and will likely continue (along with Standard8) once 3rd party negotiations have completed.
Assignee: nobody → dmose
User Story: (updated)
Stealing as I'm now actively working on this.

The plan initially is to combine loop-client into the gecko/FF code, and then separate out the standalone (link clicker UI) parts later if necessary.

Hence we'll probably move the items in the user story into future bugs.
Assignee: dmose → standard8
Attached file Commands outline
This is the rough outline of the series of commands we need to use to merge to Elm. I'll attach the filemap.txt in a moment.

I've tested this locally and it seems to be working so far. There will be some additional work to get the standalone code up and running again, which I'll handle in follow-up patches.
Attachment #8430770 - Flags: feedback?(dmose)
Attached file Loop-client to gecko-dev filemap (obsolete) —
The aim here is to get everything in approximately the right places, before the merges, and hence have a clean import of changesets.

Once we're in hg, further moves are easy to do.
Attachment #8430773 - Flags: review?(dmose)
Attached patch Make standalone tests work (obsolete) — Splinter Review
This is a follow-up patch to get the standalone tests working and running in Marionette
Attachment #8430787 - Flags: review?(dmose)
Comment on attachment 8430770 [details]
Commands outline

Looks good.  As you mentioned while we were going over it, it'll be important to be sure that test_standalone_all.py gets added towards the end of this process somehow.
Attachment #8430770 - Flags: feedback?(dmose) → feedback+
Attachment #8430773 - Flags: review?(dmose) → review+
As discussed, you may want to bring over the .gitignore into the standalone directory.
Attachment #8430787 - Flags: review?(dmose) → review+
Looks good so far; thanks for sorting through all this!
Updated for the .gitignore change.
Attachment #8430773 - Attachment is obsolete: true
Attachment #8430934 - Flags: review+
Updated to include the missing file.
Attachment #8430787 - Attachment is obsolete: true
Attachment #8430935 - Flags: review+
I believe this is enough to fix the standalone server - so that we can at least run unit tests from it. From what I can tell, it should fix it so you can make calls properly as well (this will need retesting once bug 976109 is landed).
Attachment #8430956 - Flags: review?(dmose)
Comment on attachment 8430956 [details] [diff] [review]
Fix the standalone server

Review of attachment 8430956 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose
Attachment #8430956 - Flags: review?(dmose) → review+
This updates the readme file and removes the now redundant make-links.sh.
Attachment #8431101 - Flags: review?(dmose)
Comment on attachment 8431101 [details] [diff] [review]
Rewrite readme; remove redundant make-links.sh

Review of attachment 8431101 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose, with s/stanalone/standalone/
Attachment #8431101 - Flags: review?(dmose) → review+
This is now all "fixed" - gecko-dev and loop-client have been merged onto the elm branch.

Marking as fixed for tracking purposes. If we make changes to the structure of repos later, they will be filed as new bugs.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: mozilla32 → mozilla33
Assuming verified -- needinfo me to request QA testing.
Status: RESOLVED → VERIFIED
QA Contact: anthony.s.hughes
You need to log in before you can comment on or make changes to this bug.