Closed
Bug 994643
Opened 10 years ago
Closed 10 years ago
Run jsapi-tests from test package rather than make check
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: dminor, Assigned: dminor)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
851 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
This looks like an easy thing to add to the current Cpp unit test suite.
Comment 1•10 years ago
|
||
See also bug 902594
Assignee | ||
Comment 2•10 years ago
|
||
We've been running these tests as part of the cpp unit tests successfully for several weeks and they've been added to the ./mach check-spidermonkey command, so I think it is fine to remove them from 'make check' now.
Comment 3•10 years ago
|
||
Comment on attachment 8421111 [details] [diff] [review] Remove jsapi-tests from make check Review of attachment 8421111 [details] [diff] [review]: ----------------------------------------------------------------- By all means.
Attachment #8421111 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Thanks, pushed to: https://hg.mozilla.org/integration/mozilla-inbound/rev/b51a144ea5ca
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b51a144ea5ca
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 6•10 years ago
|
||
Right now the b2g gecko tests zips contain the jsapi-tests and all of the cppunittests module making the file huge: http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/mozilla-inbound-linux64_gecko/latest/en-US/b2g-32.0a1.en-US.linux-x86_64.tests.zip Could we please look into stripping it from there? Thanks!
Comment 7•10 years ago
|
||
That got fixed in bug 1016993, FWIW.
You need to log in
before you can comment on or make changes to this bug.
Description
•