994653 - [System] no left margin at the beginning of the Confirmation prompts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Noemí Freire (:noemi)]

Is there any change in how system app implements the alert box?

STRs:
1. Launch the Messages app
2. Tap the pencil and paper icon in the upper right to compose a new message
4. Tap the attachment icon in the top right to add an attachment
5. Select a Video bigger than 300KB limit, i.e 562KB of size file

Actual:
"The file you have selected is too large" alert message appears but showing a blank space at the beginning, please see https://bug992891.bugzilla.mozilla.org/attachment.cgi?id=8404628

Environmental variables:
Device: Hamachi
BuildId: 20140410065312
Gecko: e177929
Gaia: 8697ff1
Platform version: 31.0a1


Expected:
"The file you have selected is too large" alert message appears without showing a blank space at the beginning, as it is currently shown in v1.4, please see https://bug992891.bugzilla.mozilla.org/attachment.cgi?id=8404677

Comment 1

[Maria Angeles Oteo (:oteo)]

Perhaps there could be a minor regression introduced with the refresh in modals with the new Buttons or other BB change... Setting ni to Arnau, as he's the expert in BBs :)

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Yep, this happens in all confirmation screens launched by system.
I'll take a look.

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Amy,
you recently created some specs for a system modal which uses the same CSS files:
https://bug912445.bugzilla.mozilla.org/attachment.cgi?id=8402747

This modal is based in:
http://buildingfirefoxos.com/building-blocks/confirm.html
Which has different font size. 
Is there a rule for that? And in this bug which should be the correct font size?

Thanks!

Comment 4

[Amy Lee [:amylee] UX]

(In reply to Arnau March  [:arnau] from comment #3)
> Amy,
> you recently created some specs for a system modal which uses the same CSS
> files:
> https://bug912445.bugzilla.mozilla.org/attachment.cgi?id=8402747
> 
> This modal is based in:
> http://buildingfirefoxos.com/building-blocks/confirm.html
> Which has different font size. 
> Is there a rule for that? And in this bug which should be the correct font
> size?
> 
> Thanks!

Hi Arnau, 

Please use the font size that is in my spec. The building block example that you showed looks like a different type of message and so they don't need to share the same font sizing. With that said, I think that all of the browser error messages should share the same font size so that that would need to be changed if they are currently different sizes. Please let me know if I need to file a new bug to have all the browser messages to share the same font size. Thanks!

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: no-margins.png

Now in master don't have the wait space, but the margin is not correct, so I will rename this bug.

Comment 6

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 7

[Paco Rampas [:paco]]

Attachment: margins.png

With margins like Arnau said in Comment 5

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 8428643 [details] [review]
patch in github

Probably needs a ui-review too, but r+ on the code change :)

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8428645 [details]
margins.png

Comparing this screenshot with the building blocks, looks like tittle is 5px above, and the text 10px bellow.
Another thing that would be good to fix in this patch is that all content is not centered in screen, because of the button height (70px)

Comment 10

[Paco Rampas [:paco]]

Attachment: alert-system.png

Comment 11

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8429915 [details]
alert-system.png

This one matches Confirm BB :)
Nice work!

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: ed16e2d6c079cbc7f7ad696c7b1842b09d648df6

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Please put bug number in your commit message next time. Thanks for cooperation.

Comment 14

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Sure, thanks!