994681 - [video] White outline offset to play button background

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: play_video.png

In Gallery when you select a video, the large play button background isn't aligned with the white outline. See attached screenshot.

Comment 1

[Amy Lee [:amylee] UX]

Can someone work on this one? It's been an eyesore for a while, I would love to see this fixed! Thanks

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Amy,
can you provide me the play button icon with size 100x100 or 104x104 pixels for @1x version and based on your choice all other versions @1.5x, @2x, @2.25x etc.

an I also need the color and opacity/transparency of this image: https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/style/images/video_play_normal.png

Thanks :)

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

... for this one too please :)
https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/style/images/video_play_focus.png

Comment 4

[Amy Lee [:amylee] UX]

Attachment: Play_Icon.zip

Hi Pavel, 

Here are the png's for the play icon. As for the background circle colour:

Blue Circle: #0d6c80 opacity: 80%
Grey Circle: #000000 opacity: 65% 

Let me know if you need anything else. Thanks

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 6

[Amy Lee [:amylee] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #5)
> Created attachment 8509308 [details] [review]
> patch for Gaia/master

Hi Pavel, 

Can you send me a screen shot of the video screen (also in the blue pressed stat). Thanks

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot 1

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot 2

Comment 9

[Amy Lee [:amylee] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #8)
> Created attachment 8510147 [details]
> Shot 2

Hi Pavel, 

The background circle should be INSIDE the white circle boarder. Thanks!

Comment 10

[Amy Lee [:amylee] UX]

Comment on attachment 8509308 [details] [review]
patch for Gaia/master

Hi Pavel,
The background circle should be INSIDE the white circle boarder. Thanks!

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot 1 v2

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot 2 v2

Comment 13

[Amy Lee [:amylee] UX]

Comment on attachment 8509308 [details] [review]
patch for Gaia/master

Looks good! Thanks Pavel

Comment 14

[Russ Nicoletti [:russn]]

Comment on attachment 8509308 [details] [review]
patch for Gaia/master

Hi Pavel, the patch looks good to me, but since I am not a peer of the gallery app I think it's best if Punam also reviews. I'm setting the flag for her.

Comment 15

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landing to master:
https://github.com/mozilla-b2g/gaia/commit/bbde027dac30c7e256e89540f9353566698dea22

Comment 16

[Punam Dahiya [:pdahiya]]

Comment on attachment 8509308 [details] [review]
patch for Gaia/master

Patch looks good, I assume it's tested by previous reviewers, few observations since we are no longer using images/video_play_normal.png, images/video_play_focus.png we should delete these files from gallery app.

Also, we are using play icon in camera app preview, we should check and get these changes updated in camera app video player css file.