Closed Bug 994690 Opened 7 years ago Closed 7 years ago

Refactor config loader to use promises and add unit tests to it

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmcf, Assigned: jmcf)

Details

Attachments

(1 file)

utils.config.load seems to have an old and buggy implementation. We have to re-implement using promises and a set of unit tests to it
Attached file 18215.html
patch that includes unit tests, reimplements config loader by using promises and a simpler approach, use it throughout the code. also fixes an associated race condition in the fb_init.js code
Attachment #8405278 - Flags: review?(francisco.jordano)
without this patch in the curren(In reply to Jose M. Cantera from comment #1)
> Created attachment 8405278 [details]
> 18215.html
> 
> patch that includes unit tests, reimplements config loader by using promises
> and a simpler approach, use it throughout the code. also fixes an associated
> race condition in the fb_init.js code

without this patch when we have moved some files to separate FTU and comms we are getting intermittent failures like

E/GeckoConsole(10529): Content JS ERROR at app://communications.gaiamobile.org/contacts/js/fb/fb_init.js:38 in fb.init/req.onerror: Contacts: Error while checking if FB is enabled 500
Comment on attachment 8405278 [details]
18215.html

LGTM, left some comments in github.

Thanks!
Attachment #8405278 - Flags: review?(francisco.jordano) → review+
Flags: in-testsuite+
landed in master:

https://github.com/jmcanterafonseca/gaia/commit/d2207336489d0685f041459cc859e67b96e51257
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.