994722 - i81n callback called twice in a row regardless of error state

Status: RESOLVED FIXED

(Webmaker Graveyard :: Localization, defect)

Description

[Bobby Richter [:secretrobotron]]

https://github.com/mozilla/node-webmaker-i18n/blob/master/i18n.js#L251

Found this code trying to debug our usage of i18n:

  if(!errFlag) {
    callback(error, false);
  }
  callback(null, true);

Looks like a `return` is missing.

Btw, what's the point of the flag? Is it different than checking for absence of error?

Comment 1

[Ali Al Dallal [:alicoding]]

Attachment: https://github.com/mozilla/node-webmaker-i18n/pull/48

Comment 2

[Ali Al Dallal [:alicoding]]

Merged https://github.com/alicoding/node-webmaker-i18n/commit/696e68ba0afc5f44433a43ec78665b2ff67621ab