994733 - Text selection handles should snap to character and line breaks

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

When dragging the selection handles around, I don't think they should float freely. Instead, they should snap to character and line breaks (like other handles on Android).

Comment 1

[Mark Capella [:capella]]

Attachment: bugCursor.diff

If I recall correctly, this bug was about how we differ from Chrome when selecting text in input elements. We allow the user to drag the UI handles around the screen, outside the editable, though we confine the actual text selection to the editable contents. On handle release, we snap the handle back to the right place.

This rough WIP contricts the handle positions internal to the editable as Chrome, Browser, etc. does.

Comment 2

[Mark Capella [:capella]]

Attachment: bugHandles.diff

Removed the debug code.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8494620 [details] [diff] [review]
bugHandles.diff

Review of attachment 8494620 [details] [diff] [review]:
-----------------------------------------------------------------

I worry a bit about making this "synchronous", but it seems to work well. Happy to give it a ride.

::: mobile/android/base/TextSelectionHandle.java
@@ +136,5 @@
> +
> +                // If we're positioning a cursor, don't move the handle here. Gecko
> +                // will tell us the position of the caret, so we set the handle
> +                // position then. This allows us to lock the handle to wherever the
> +                // caret appears.

I don't think this comment is correct anymore.

Comment 4

[Mark Capella [:capella]]

Pruning some old bugs obviated by new Core/Layout AccessibleCaret implementation, or being no longer observable.

(Please re-open if appropriate.)