Closed
Bug 994811
Opened 10 years ago
Closed 10 years ago
Add a ToJSValue overload for dictionary types.
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(2 files)
|
1.13 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
|
4.24 KB,
patch
|
airpingu
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8404829 -
Flags: review?(bobbyholley)
|
|
Assignee | |
Comment 2•10 years ago
|
||
There is one behavior change here: the the old code converted null strings in the MmsDeliveryInfo into "", but the new code will convert them to a JS null value.
Attachment #8404830 -
Flags: review?(gene.lian)
|
||
Updated•10 years ago
|
Attachment #8404829 -
Flags: review?(bobbyholley) → review+
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8404830 [details] [diff] [review] part 2. Use ToJSValue in msMessage::GetDeliveryInfo. Review of attachment 8404830 [details] [diff] [review]: ----------------------------------------------------------------- Awesome codes! Thanks Boris! I think it's OK to return nulls because I don't think we would return "" for them in the old codes because they must have some valid values.
Attachment #8404830 -
Flags: review?(gene.lian) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d621c19841e remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/7edfd7d6cbec
Flags: in-testsuite-
Whiteboard: [need review]
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4d621c19841e https://hg.mozilla.org/mozilla-central/rev/7edfd7d6cbec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•