Closed
Bug 994844
Opened 10 years ago
Closed 10 years ago
CustomizeMode.populatePalette() uses Task.spawn() although it doesn't need to
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 31
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file)
|
3.67 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
CustomizeMode.populatePalette() return a promise using Task.spawn() although the method itself is completely sync.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8404854 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8404854 [details] [diff] [review] 0001-Bug-994844-Remove-Task.spawn-usage-from-CustomizeMod.patch Assuming our tests pass, I'm happy with this.
Attachment #8404854 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 3•10 years ago
|
||
(the mochitest-browser tests under browser/components/customizableui/test)
|
|
Assignee | |
Comment 4•10 years ago
|
||
I did run them. And they did pass. On my machine that is :)
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a1f47564a3be
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1f47564a3be
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
You need to log in
before you can comment on or make changes to this bug.
Description
•