Closed Bug 994999 Opened 6 years ago Closed 6 years ago

PC.IsClosed() should refer to SignalingState not media presence

Categories

(Core :: WebRTC: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

PeerConnectionImpl.IsClosed() verifies if the PC has media or not. I would expect this function to report if the PC SignalingState is in closed or not.
This patch renames the IsClosed() function to HasMedia() and changes the behavior of IsClosed() to return if SignalingState is in the closed state.
Attachment #8405066 - Flags: review?(rjesup)
Attachment #8405066 - Flags: review?(docfaraday)
Attachment #8405066 - Flags: review?(rjesup) → review+
Comment on attachment 8405066 [details] [diff] [review]
rename_isclosed_to_hasmedia.patch

Review of attachment 8405066 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable to me.
Attachment #8405066 - Flags: review?(docfaraday) → review+
Assignee: nobody → drno
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d1e74ffe92ac
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.