99501 - JS error in viewZoomOverlay.js at startup

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Simon Fraser [no longer active]]

I now get this JS error on every startup:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this.bundle has no properties" {file: 
"chrome://communicator/content/viewZoomOverlay.js" line: 49}]' when calling 
method: [nsIDOMEventListener::handleEvent]"  nsresult: "0x80570021 
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "<unknown>"  data: yes]
************************************************************

Comment 1

[jag (Peter Annema)]

Hmm, yeah. It looks like the binding isn't quite ready yet when we use it there
(though it is on other platforms, seems to be some timing thing).

I think I can get rid of the dependency on having the bindings load in some
specific order.

Comment 2

[Pierre Saslawsky]

(just for the record - you seem to know what the problem is...)
The assert appeared after my checkin for bug 39117 and apparently it was not 
fixed by pink's checkin for bug 97549.

Comment 3

[jag (Peter Annema)]

Yes. Basically it was a latent problem waiting to surface. Thanks to pleasant
timing on Windows and Linux, this code wasn't called until the stringbundle
binding in question had already been bound to. On the Mac, which until recently
(your checkin) didn't use this code, the timing is different and this warning
shows up. It's code that can actually just be removed if I remember this
correctly, so ...

Comment 4

[jag (Peter Annema)]

-> 0.9.6

Comment 5

[jag (Peter Annema)]

-> 0.9.7

Comment 6

[Simon Fraser [no longer active]]

Current builds are giving me 3 (three) JS errors on startup, possibly unrelated 
to this one.

Comment 7

[jag (Peter Annema)]

Scratch all that. hiddenWindow.xul loads this code without having a place for
the stringbundle to overlay on. This causes the error, which causes the rest of
the init code to not run, which in turn causes the Text Zoom menu item to remain
hidden. I guess what we'd want is for the menu item to be there, but disabled.

Patch coming up.

Comment 8

[jag (Peter Annema)]

Attachment: Fix js error at startup on Mac (-uw)

Comment 9

[Simon Fraser [no longer active]]

Comment on attachment 59836 [details] [diff] [review]
Fix js error at startup on Mac (-uw)

r=sfraser

Comment 10

[Joe Hewitt (gone)]

Comment on attachment 59836 [details] [diff] [review]
Fix js error at startup on Mac (-uw)

sr=hewitt

Comment 11

[jag (Peter Annema)]

Checked in.

Comment 12

[sairuh (rarely reading bugmail)]

don't see this error in the js console after startup. vrfy'd fixed on mac 10.1.1
and 9.1 with 2001.12.05.0x comm verif bits.