Closed Bug 995036 Opened 10 years ago Closed 10 years ago

[Flame] flash.sh doesn't take into account the flame device to flash

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhirata, Unassigned)

References

Details

Attachments

(1 file)

after building for the flame, run the ./flash.sh script from the project directory

Expected: flame flashes
Actual: Unsupported device "", can't flash
Attached file Pull request #338
Patch
Attachment #8405116 - Flags: review?(mwu)
PRODUCT_NAME deprecates DEVICE in config.sh. Instead, put in a fallback in load-config.sh that sets DEVICE from PRODUCT_NAME if DEVICE isn't set.
Blocks: 978888
Attachment #8405116 - Flags: review?(mwu)
Actually - this should be really easy. I just realized I have all the right fallback logic already, but it's in setup.sh. You should be able to just move that logic (for all 4 variables - VARIANT, PRODUCT_NAME, DEVICE, and LUNCH) from setup.sh to load-config.sh.
Comment on attachment 8405116 [details]
Pull request #338

Made changes as suggested.
Attachment #8405116 - Flags: review?(mwu)
Comment on attachment 8405116 [details]
Pull request #338

r=me with the whitespace change removed.
Attachment #8405116 - Flags: review?(mwu) → review+
nhirata merged commit 05279c1 into mozilla-b2g:master from nhirata:bug_995036 

https://github.com/mozilla-b2g/B2G/commit/05279c163a4f6ecbcf8b5dec78ccc98b75e0cc2e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: