Closed
Bug 995096
Opened 7 years ago
Closed 7 years ago
New Sync page: title is broken for RTL languages, show unneeded horizontal scrollbar
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: flod, Assigned: tchevalier)
References
()
Details
Attachments
(1 file)
https://www-dev.allizom.org/he/firefox/sync/ Title keeps the structure of LTR, Sync logo should move to the left. Looking into it.
| Reporter | ||
Comment 1•7 years ago
|
||
Assigning to Théo, so he can get started with Bedrock :-)
Assignee: francesco.lodolo → tchevalier
| Reporter | ||
Updated•7 years ago
|
Summary: New Sync page: title is broken for RTL languages → New Sync page: title is broken for RTL languages, show unneeded horizontal scrollbar
| Assignee | ||
Comment 2•7 years ago
|
||
This fixes the Sync page, (layout + scroll bar). It also fixes Tabzilla on many pages like /he/firefox/channel/ where Tabzilla button should be on the left.
Attachment #8405630 -
Flags: review?(steven)
| Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8405630 [details] [review] PR Asking Jon for review since Steven is busy
Attachment #8405630 -
Flags: review?(steven) → review?(jon)
Comment 4•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/bcde6f04404ccd2ea242a7d244602fb9ed534277 [Bug 995096] New Sync page: title is broken for RTL languages https://github.com/mozilla/bedrock/commit/c691ebbfbf3870744df7f1f326d0b5a93e658530 Merge pull request #1877 from TheoChevalier/995096-sync-rtl-fix [Bug 995096] - New Sync page: title is broken for RTL languages, show unneeded horizontal scrollbar
Comment 5•7 years ago
|
||
fixed on dev and stage https://www-dev.allizom.org/he/firefox/sync/
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
| Reporter | ||
Comment 6•7 years ago
|
||
Verified on prod https://www.mozilla.org/ar/firefox/sync/ https://www.mozilla.org/he/firefox/sync/
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Attachment #8405630 -
Flags: feedback+
Updated•7 years ago
|
Attachment #8405630 -
Flags: review?(jon) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•