Closed Bug 995096 Opened 7 years ago Closed 7 years ago

New Sync page: title is broken for RTL languages, show unneeded horizontal scrollbar

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: flod, Assigned: tchevalier)

References

()

Details

Attachments

(1 file)

PR
44 bytes, text/x-github-pull-request
jpetto
: review+
jpetto
: feedback+
Details | Review
https://www-dev.allizom.org/he/firefox/sync/

Title keeps the structure of LTR, Sync logo should move to the left. 

Looking into it.
Assigning to Théo, so he can get started with Bedrock :-)
Assignee: francesco.lodolo → tchevalier
Summary: New Sync page: title is broken for RTL languages → New Sync page: title is broken for RTL languages, show unneeded horizontal scrollbar
Attached file PR
This fixes the Sync page, (layout + scroll bar).
It also fixes Tabzilla on many pages like /he/firefox/channel/ where Tabzilla button should be on the left.
Attachment #8405630 - Flags: review?(steven)
Comment on attachment 8405630 [details] [review]
PR

Asking Jon for review since Steven is busy
Attachment #8405630 - Flags: review?(steven) → review?(jon)
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/bcde6f04404ccd2ea242a7d244602fb9ed534277
[Bug 995096] New Sync page: title is broken for RTL languages

https://github.com/mozilla/bedrock/commit/c691ebbfbf3870744df7f1f326d0b5a93e658530
Merge pull request #1877 from TheoChevalier/995096-sync-rtl-fix

[Bug 995096] - New Sync page: title is broken for RTL languages, show unneeded horizontal scrollbar
fixed on dev and stage https://www-dev.allizom.org/he/firefox/sync/
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attachment #8405630 - Flags: feedback+
Attachment #8405630 - Flags: review?(jon) → review+
You need to log in before you can comment on or make changes to this bug.