995135 - "Search Google for ..." should honor "When I open a link in a new tab, ..."

Status: RESOLVED INVALID

(Firefox :: Untriaged, defect)

Description

[pionchon.luc]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140317233339

Steps to reproduce:

1. Open "Tabs" preferences
2. uncheck "When I opn a link in a new tab, switch to it immediately"
3. select some text
4. open the contextual menu (right click)
5. select "Search Google for ..."



Actual results:

a new tab is created and FF switch to it immediately


Expected results:

a new tab should be created, but FF should not switch to it.

Comment 1

[:Gijs (he/him)]

Between bug 765619 / bug 707672, and bug 331222, I don't know whether this is expected and/or when this changed. Dão?

Comment 2

[Mardeg]

bug 761836 mentions it was an intentional change but isn't blocking/depending on any bug that switched
about:config?filter=browser.search.context.loadInBackground
to false by default.

Comment 3

[:Gijs (he/him)]

(In reply to Mardeg from comment #2)
> bug 761836 mentions it was an intentional change but isn't
> blocking/depending on any bug that switched
> about:config?filter=browser.search.context.loadInBackground
> to false by default.

The default value of the pref isn't at issue, though - the fact that the pref doesn't affect the result of searching from the context menu is. And that's not addressed by the comments in bug 761836.

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Mardeg from comment #2)
> > bug 761836 mentions it was an intentional change but isn't
> > blocking/depending on any bug that switched
> > about:config?filter=browser.search.context.loadInBackground
> > to false by default.
> 
> The default value of the pref isn't at issue, though - the fact that the
> pref doesn't affect the result of searching from the context menu is. And
> that's not addressed by the comments in bug 761836.

Sorry, I need to read more carefully. The about:config pref browser.search.context.loadInBackground governs these loads, but browser.tabs.loadInBackground (which is the thing that's in the UI options) doesn't. Sigh.

Anyway, that basically means this is invalid, AFAICT. Reporter, you can use the aforementioned pref in about:config to change how the search context menu behaves.

That said, maybe we should consider simplifying all these options into one, because having separate ones for all of the behaviours is really confusing, especially when only one of them is in the UI. :-\

Comment 5

[Mardeg]

bug 695482 was filed to prevent browser.tabs.loadInBackground affecting the context search.
Then bug 727131 was filed for the new pref browser.search.context.loadInBackground to control how context searches loaded.

Comment 6

[pionchon.luc]

(In reply to :Gijs Kruitbosch from comment #4)

> Anyway, that basically means this is invalid, AFAICT. Reporter, you can use
> the aforementioned pref in about:config to change how the search context
> menu behaves.

I did that. thanks.
however,

> That said, maybe we should consider simplifying all these options into one,
> because having separate ones for all of the behaviours is really confusing,
> especially when only one of them is in the UI. :-\

indeed.
I consider this being a bug.
I let you open a proper report.

Note also that addons like tineye search [1] does not listen to browser.search.context.loadInBackground which makes it even more confusing.

[1] https://addons.mozilla.org/en-US/firefox/addon/tineye-reverse-image-search

Comment 7

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #4)
> Sorry, I need to read more carefully. The about:config pref
> browser.search.context.loadInBackground governs these loads, but
> browser.tabs.loadInBackground (which is the thing that's in the UI options)
> doesn't. Sigh.
...
> That said, maybe we should consider simplifying all these options into one,
> because having separate ones for all of the behaviours is really confusing,
> especially when only one of them is in the UI. :-\

Except that they have different default values (intentionally so, because it results in the default behavior we want), so it's unclear how they'd be unified.

Comment 8

[pionchon.luc]

(In reply to Dão Gottwald [:dao] from comment #7)

> Except that they have different default values (intentionally so, because it
> results in the default behavior we want), so it's unclear how they'd be
> unified.

If there is a good reason to have different defaults, that reason should also be good enough to have a different line in the Tabs preferences. IMHO.