995187 - Call log is not showing the full phone number

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Florin Strugariu [:Bebe]]

Attachment: screenshot from jenkins

Description:
Our test is failing because the phone number that is shown in call log is not the same as the dialled number 

Environment:
Gaia      6c50349f41d40ba175ea0fc0c2c2cbd739ba7170
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/28b419f0e857
BuildID   20140411000202
Version   30.0a2
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013


Traceback (most recent call last):
File "/var/jenkins/workspace/b2g.hamachi.mozilla-aurora.ui/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
testMethod()
File "/var/jenkins/workspace/b2g.hamachi.mozilla-aurora.ui/tests/python/gaia-ui-tests/gaiatest/tests/functional/dialer/test_call_log_all_calls.py", line 41, in test_call_log_all_calls
self.assertIn(test_phone_number, call_log.first_all_call_text)
AssertionError: u'[phone]' not found in u'18007072533\n5:51 AM'


Reproducible manually: NO

STR:
1. open the dialer app
2. enter [phone] (with the '+' char)
3. tap call 
4. tap end call
5. go to call log 
6. verify the dialled number

Expected:
6. The same number is in the call log: [phone]

Actual:
6. the first char of the number "+" is missing from the call log

We can't reproduce here locally using automation and manual testing 
can someone from the US take a look maybe it's a local thing.


It's the first time this test failed in a long while on 1.4

Comment 1

[Tony Nguyen]

I cannot reproduce this issue. I tested this dialing out to multiple numbers with the '+' prefix and all of the entries in the call log match the dialed numbers. 

Environmental Variables:
Device: Buri v1.4 mozRIL
BuildID: 20140410000201
Gaia: 9b2da43dfee3792cd311ae55f0b06272313208f0
Gecko: 9d9ead7d6afa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 2

[Florin Strugariu [:Bebe]]

OK it might be a one time fail 

I will take a look over thin in 2-3 days and see if it fails again if not I will close the bug.

Comment 3

[Florin Strugariu [:Bebe]]

In the last 11 builds this test passed so it looks like the build is OK

Comment 4

[Florin Strugariu [:Bebe]]

http://selenium.qa.mtv2.mozilla.com:8080/view/B2G%20Hamachi/job/b2g.hamachi.mozilla-aurora.ui/117/testReport/test_call_log_all_calls/history/?

Comment 5

[Robert Chira [:RobertC]]

This issue occured again in the Jenkins test run:
http://selenium.qa.mtv2.mozilla.com:8080/view/B2G%20Aurora/job/b2g.hamachi.mozilla-aurora.ui.smoketest/136/HTML_Report/?

Build info:
Gaia      4eb2393e6a5174e6c732167866aded046c49ed97
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/ec8c6e42acf2
BuildID   20140425000201
Version   30.0a2
ro.build.version.incremental=eng.tclxa.20131223.163538
ro.build.date=Mon Dec 23 16:36:04 CST 2013

Is it possible that the test doesn't type the "+" character? In this case I would expect the phone number to have "0" at the beginning.
Maybe we should also add an assert when making a call that the phone number is correct.

Comment 6

[Robert Chira [:RobertC]]

Attachment: Pull request

Comment 7

[Zac C (:zac)]

As this is an enhancement rather than a bug fix, did you consider raising it to master branch and then we can uplift it?

Comment 8

[Robert Chira [:RobertC]]

I will create a new PR for master with the same changes.

Comment 9

[Robert Chira [:RobertC]]

Attachment: Pull request master

Comment 10

[Zac C (:zac)]

Comment on attachment 8413704 [details] [review]
Pull request master

Small tweak to the locators to reduce dupes.
Aside from that the functionality is good :)

Comment 11

[Zac C (:zac)]

Comment on attachment 8413704 [details] [review]
Pull request master

Also, the assertion is causing test_mmi.py to fail every time but the test is passing fine.

I think we should remove the assertion and keep the new wait which is an improvement.

Comment 12

[Zac C (:zac)]

Comment on attachment 8412587 [details] [review]
Pull request

r-, don't merge this one, we'll fix the master one first.

Comment 13

[Robert Chira [:RobertC]]

Updated the pull requests. I removed the assert because of test_mmi (when typing the last character of the IMEI the frame would change).

Comment 14

[Zac C (:zac)]

Comment on attachment 8413704 [details] [review]
Pull request master

r+ from me too, much cleaner solution :))

Comment 15

[Zac C (:zac)]

Master:
https://github.com/mozilla-b2g/gaia/commit/1317b5713b35b1ab091d87adb6621d56383baf2a
v1.4:
https://github.com/mozilla-b2g/gaia/commit/92f26016de320e09a9baa7477e61ccde89908591

Comment 16

[Zac C (:zac)]

Comment on attachment 8412587 [details] [review]
Pull request

r+, landed directly to v1.4

Comment 17

[Zac C (:zac)]

Backout master:
https://github.com/mozilla-b2g/gaia/commit/68aaf2617dfa80a0eaa67139b5ba9e783817d109

Backout v1.4:
https://github.com/mozilla-b2g/gaia/commit/ef63d261ca4ba5639477d98a79212124246f8226

Comment 18

[Zac C (:zac)]

This broke test_sms_to_dialer

Comment 19

[Robert Chira [:RobertC]]

Attachment: Pull request master

If this patch will be merged I'll uplift it to 1.4

Comment 20

[Zac C (:zac)]

Comment on attachment 8431444 [details] [review]
Pull request master

r+!

Comment 21

[Zac C (:zac)]

Merged for master:
https://github.com/mozilla-b2g/gaia/commit/48e46a99e98cf9d7fd16bd4ed7c51fa72fa2d9e9

Comment 22

[Robert Chira [:RobertC]]

Attachment: Pull request v1.4

Comment 23

[Florin Strugariu [:Bebe]]

Comment on attachment 8431567 [details] [review]
Pull request v1.4

Works OK

Comment 24

[[:AndreiH]]

Comment on attachment 8431567 [details] [review]
Pull request v1.4

Merged v1.4:
https://github.com/mozilla-b2g/gaia/commit/371d74ea85d87aa5eb38b1132e38db52b5c2d714