Closed
Bug 995287
Opened 10 years ago
Closed 10 years ago
Static completed progressbar triggers 20 FPS recomposites
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: BenWa, Assigned: mstange)
Details
(Keywords: power)
Attachments
(2 files, 1 obsolete file)
30 bytes,
text/html
|
Details | |
1.71 KB,
patch
|
Details | Diff | Splinter Review |
Tested on mac. A progress bar, even if it's hidden behind another element, triggers 20 FPS re-composite draining my battery.
Comment 1•10 years ago
|
||
Is this a dupe of bug 962594?
Reporter | ||
Comment 2•10 years ago
|
||
No, we also recomposite at 20 FPS when the progressbar is visible not animated on mac.
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8421916 -
Flags: review?(bgirard)
Assignee | ||
Comment 4•10 years ago
|
||
huh, tabs... I'll fix the whitespace on checkin.
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8421916 [details] [diff] [review] dont repaint completed progressbars Review of attachment 8421916 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/cocoa/nsNativeThemeCocoa.mm @@ +2401,5 @@ > + { > + double value = GetProgressValue(aFrame); > + double maxValue = GetProgressMaxValue(aFrame); > + // Don't request repaints for scrollbars at 100% because those don't animate. > + if (value < maxValue && !QueueAnimatedContentForRefresh(aFrame->GetContent(), 30)) { I really don't like on relying on short circuit to avoid a function call. It much easier to understand: if (value < maxValue) if (!QueueAnimatedContentForRefresh(aFrame->GetContent(), 30))
Attachment #8421916 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d6d1d760d02
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mstange
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/1d6d1d760d02
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•