995316 - Make GeckoLayerClient package scoped

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

A window of opportunity has opened and I would like to take it to reduce GeckoLayerClient's visibility.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Expose OnMetricsChangedListener via LayerView

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Scope GLC down

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Try push at https://tbpl.mozilla.org/?tree=Try&rev=953594a55f50

These changes require one of the patches from bug 895463 which landed on fx-team recently.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8405493 [details] [diff] [review]
Part 2 - Scope GLC down

Review of attachment 8405493 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/gfx/LayerView.java
@@ +327,5 @@
>          }
>      }
>  
>      @RobocopTarget
> +    public Object getLayerClient() { return mLayerClient; }

Oh I forgot to remove @RobocopTarget, done locally.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8405493 [details] [diff] [review]
Part 2 - Scope GLC down

I failed at building locally, and try failed my build in return. Need to fix this patch, unflagging for review for now.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Scope GLC down

Ok, this one compiles locally for realz.

https://tbpl.mozilla.org/?tree=Try&rev=79908cf91b08

Comment 7

[Kartikaya Gupta (email:[e-mail])]

remote:   https://hg.mozilla.org/integration/fx-team/rev/2a404bf79a6b
remote:   https://hg.mozilla.org/integration/fx-team/rev/745e3881973e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2a404bf79a6b
https://hg.mozilla.org/mozilla-central/rev/745e3881973e