99541 - Create Link is an option in the right-click menu when a link is highlighted

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[TucsonTester2]

After creating a link in composer and right clicking it, in the pop-up menu it
gives an option to create a link even though there is a link already in place.

Build:  2001091003

Reproducibility: Every time

Steps to Reproduce:
1. Open Composer
2. Type in some text and highlight it
3. Click on the link button in the toolbar and create a link then click ok
4. Right click on the link

Actual Results:
Once you right click on the link you will see that there is an option for
"Create Link".

Expected Results:
I would expect that the "Create Link" option would not be in this menu since the
text I right-clicked on was already a link.  If you do click on "Create Link" it
just brings up the Link Properties window which is already an option of it's own
on the right-click menu.  I believe that this makes it uneccessary to have in
this menu.

Comment 1

[kinmoz]

--> syd

Comment 2

[michael wendell]

Confirmed on Win 2k using build 20010927.

Comment 3

[Syd Logan]

I'd chime in that Remove Links should be Remove Link (why is it plural), we
should convert the Create Link to Edit Link Properties..., and we should remove
the Link Properties from the bottom of the menu.

But anyway, marking future, not an EDITORBASE bug.

Comment 4

[Robin Whittle]

This bug is related to a problem I raise in bug 142042: "Image right-click 
Create Link is inconsistent with other ways of adding a link".


This "Image right-click Create Link" leads to a different dialog box than 
the "Image Properties > Link Tab" dialog box which is reached by the three
other, more normal (I guess) ways of adding a link.  

Furthermore, this different dialog box does not have an option regarding 
the border of the image, whereas the "Image Properties > Link Tab" does.  
This border option and related problems with borders of images with links 
is the subject of my bug 142093.

Comment 5

[Robin Whittle]

Please see discussion of this "Create Link" right-click menu item in bug 142042.

 - Robin

Comment 6

[Charles Manske]

Easy to fix. Changing milestone

Comment 7

[Charles Manske]

Assinging to me - fix comming soon.

Comment 8

[Charles Manske]

Attachment: patch v1

This disables "Create Link" command appropriately. Needed extra code to handle
detection of link around image as well.

Comment 9

[Kathleen :Brade]

Comment on attachment 91556 [details] [diff] [review]
patch v1

In this block:

+  if (isImage)
+  {
+    var htmlEditor = window.editorShell.editor.QueryInterface(nsIHTMLEditor);
+    isInLink = htmlEditor.getElementOrParentByTagName("href",
GetObjectForProperties());
+  }

It should be rewritten like this (please verify that this works; the parameters
to getElementOrParentByTagName don't seem correct to me but I haven't checked):
  if (isImage)
    isInLink = gEditor.getElementOrParentByTagName("href",
GetObjectForProperties());

Comment 10

[Charles Manske]

Attachment: patch v2

Use "gEditor" as suggested

Comment 11

[Kathleen :Brade]

Comment on attachment 91827 [details] [diff] [review]
patch v2

r=brade

Comment 12

[kinmoz]

Comment on attachment 91827 [details] [diff] [review]
patch v2

sr=[e-mail]

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 91827 [details] [diff] [review]
patch v2

a=asa (on behalf of drivers) for checkin to 1.1

Comment 14

[Charles Manske]

Checked into 1.1 trunk