995412 - Graphic assets for desktop Sync should be run through an optimizer to reduce size

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: imageOptim.png

I can't guarantee that this won't introduce issues, but if you run the image assets through an optimizer (I use ImageOptim on Mac with includes several) you can save a lot on file size. See attached example for welcome graphic.

Comment 1

[Richard Newman [:rnewman]]

I actually pngquanted everything for Android (Bug 959833); the changes Nick landed might have undone that. I don't think anything's been done for desktop. Is this bug for desktop?

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #1)
> I actually pngquanted everything for Android (Bug 959833); the changes Nick
> landed might have undone that. I don't think anything's been done for
> desktop. Is this bug for desktop?

I certainly used pngquant when landing new assets: https://bugzilla.mozilla.org/show_bug.cgi?id=974129#c10.

I'm guessing this is desktop only.

Comment 3

[Ryan Feeley [:rfeeley]]

I only tested this on desktop. Glad to hear you squish first!

Comment 4

[Richard Newman [:rnewman]]

I attempted to quantize these myself, and I noticed odd color shifting -- presumably the original tools had set some flag than pngquant doesn't respect.

pngcrush appeared visually indistinguishable, and knocked 30% off the file size, so done (for the three files in aboutaccounts/):

https://hg.mozilla.org/integration/fx-team/rev/c2ba65436960

Comment 5

[Ryan Feeley [:rfeeley]]

Richard, that could be the colour profile embedded in the PNG. I wish they hadn't included colour profiles in the spec. Just makes a mess.

Mark, can you handle this issue for desktop? The graphic assets need optimizing.

Comment 6

[Richard Newman [:rnewman]]

(In reply to Ryan Feeley from comment #5)

> Mark, can you handle this issue for desktop? The graphic assets need
> optimizing.

I did the three desktop ones I found -- I just only used pngcrush, not pngquant. The Android ones are already quanted.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2ba65436960