Build: 2001091003 If you add in text styles before you begin typing in composer then click on an alighnment button the text will not center nor will the html be added, but the alignment button shows as if the text is aligned differently. Reproducibility: Every time Steps to Reproduce: 1. Open composer 2. Click on the Bold button on the toolbar 3. Click on the Center alignment button on the toolbar 4. Type in some text Actual Resutls: You will notice that the alignment will show it's centered in the toolbar, but in the actual page itself it does not show the centered alignment. If you take a look at the HTML source you will see that there was no div tag added. Also the bold option is removed, I don't know if this is another bug or not but that also happens. Expected Results: I would expect that the alignment and bold options would stick. And that the correct alignment would be displayed.
Confirmed on build 2001091303.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.6
Assignee: kin → jfrancis
Status: ASSIGNED → NEW
Priority: P3 → --
Target Milestone: mozilla0.9.6 → ---
Status: NEW → ASSIGNED
Whiteboard: EDITORBASE; 1 day
Target Milestone: --- → mozilla0.9.7
More information on this report. If you click the Alignment button BEFORE clicking the text style button, it will work properly. If you choose any other text style before clicking on the Alignment button, it will not work. The tags are not placed in the html source.
This problem also seems to happen if you start with a different color. It affects all font stylings and all alignments. I am using build 2001121003 and win ME.
Joe--is this a bug Daniel could help with? Daniel--is this still a bug after your landing?
pushing off 098 to 099
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Created attachment 65980 [details] [diff] [review] patch v1.0 Joe, Kin, can you review this patch please ?
Whiteboard: EDITORBASE; 1 day → EDITORBASE+; 1 day
Comment on attachment 65980 [details] [diff] [review] patch v1.0 Get and r=jfrancis and you got my firstname.lastname@example.org. - Initialize divType with it's value when it's declared. - I don't think you need to vars tmp and theElement in the while loop.
Attachment #65980 - Flags: superreview+
My last statement above should have said "two vars".
Comment on attachment 65980 [details] [diff] [review] patch v1.0 I feel bad about vetoing this patch, but i think it's the right thing. Other recent bug fixes have gotten things to the point where things are almost working already. The only remaining problem in the current tip is that we need a br node inside this div so that we get a proper caret. Otherwise this is already working. I think the right thing to do here to check at postprocessing time (AfterEditInner) if we are in an empty block, and if put in a br. I beleive the best place to put this code is either in AdjustSelection() or by overriding CreateBogusNode() in the html rules and adding it there.
Attachment #65980 - Flags: needs-work+
Hey, I had this code in Adjustselection() (I had just put it in last week!) I reordered some things so that it always happens now, instead of sometimes. This fixes this bug and 103677.
Whiteboard: EDITORBASE+; 1 day → EDITORBASE+; FIXINHAND; patch in bug 103677
fixed on tip
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Verified on Win XP using trunk build 02-20.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.