995550 - Add "Connect Console" to "This Frame" context menu

Status: RESOLVED INACTIVE

(DevTools :: Console, enhancement, P3)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Now that we can connect the web console to subframes, we could simplify things by making it possible via the mouse as well.  Part of the context menu when right-clicking an inner frame includes a "This Frame" section.  We should add a "Connect Console" option (or similar) that opens the console already targeting the given frame.

Comment 1

[Brian Grinstead [:bgrins]]

I think this will have some complex interaction with the 'select frame' feature at the toolbox level.  It could get complicated to have selected a frame at the webconsole level and then change one at the upper level (which would reset the selection in the webconsole).  Or, select one at the upper level and then the dropdown in the console would presumably have to be filtered to only include frames contained within the currently selected frame (new server method would be needed for that, I think).  These issues currently exist with 'cd' but are much less noticeable.

One option would be to make the current 'select frame' feature Browser Toolbox / chrome level only and then implemented a UI for this in the console.  That's a product decision, but it would match parity with other tools.  I guess the question is if people only care about switching frames for console or if they'd rather have it happen across the whole toolbox.  If the former, then moving it to the console level would be ideal (and clean up one more button from the top-level UI).

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Not sure of the original context, but with the iframe picker we now only show the message from the given selected frame