Tracelogger: Log VM calls

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: h4writer, Assigned: h4writer)

Tracking

unspecified
mozilla31
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Luke mentioned a long long long time ago it would be very interesting to log VM calls. At that time I thought tracelogger wasn't ready to handle that much data. Fast forward to now and I now feel comfortable to add this. It wouldn't be enabled by default, but it can get enabled by adjusting an environment variable:

TLLOG=Default,VM js foo.js
This patch does 2 things:
- add loggers around VM calls
- don't add instrumentation in asm code for disabled textIds

TODO (followup-work:
- I didn't find an immediate elegant way to do this for the CallWithABI thing.
- This doesn't log which vm call is called.
Assignee: nobody → hv1989
Attachment #8405746 - Flags: review?(luke)
Comment on attachment 8405746 [details] [diff] [review]
Add loggers around callVM

Cool
Attachment #8405746 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/e7f563c9c7b8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.