Closed
Bug 995570
Opened 10 years ago
Closed 10 years ago
Tracelogger: Log VM calls
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: h4writer, Assigned: h4writer)
Details
Attachments
(1 file)
6.07 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Luke mentioned a long long long time ago it would be very interesting to log VM calls. At that time I thought tracelogger wasn't ready to handle that much data. Fast forward to now and I now feel comfortable to add this. It wouldn't be enabled by default, but it can get enabled by adjusting an environment variable: TLLOG=Default,VM js foo.js
Assignee | ||
Comment 1•10 years ago
|
||
This patch does 2 things: - add loggers around VM calls - don't add instrumentation in asm code for disabled textIds TODO (followup-work: - I didn't find an immediate elegant way to do this for the CallWithABI thing. - This doesn't log which vm call is called.
Assignee: nobody → hv1989
Attachment #8405746 -
Flags: review?(luke)
Comment 2•10 years ago
|
||
Comment on attachment 8405746 [details] [diff] [review] Add loggers around callVM Cool
Attachment #8405746 -
Flags: review?(luke) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7f563c9c7b8
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e7f563c9c7b8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•