Closed Bug 995654 Opened 6 years ago Closed 6 years ago

Suppress gcc -Wuninitialized warning in third-party code: libvorbis

Categories

(Core :: Audio/Video, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31
Tracking Status
firefox30 --- wontfix
firefox31 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

gcc reports one -Wuninitialized warning in libvorbis:

media/libvorbis/lib/os.h:102:40: [-Wuninitialized] variable 'temp' is uninitialized when used here

IIUC, this is a false positive because gcc is confused when taking the address of temp in this __asm__ block:

https://hg.mozilla.org/mozilla-central/annotate/ebdf2740dc3e/media/libvorbis/lib/os.h#l102
Attachment #8405791 - Flags: review?(tterribe)
Comment on attachment 8405791 [details] [diff] [review]
suppress-Wuninitialized-warnings.patch

Review of attachment 8405791 [details] [diff] [review]:
-----------------------------------------------------------------

I think changing the constraint to "=m" instead of "m" (and moving it to the outputs list) would also fix the problem, but this approach is fine with me.
Attachment #8405791 - Flags: review?(tterribe) → review+
https://hg.mozilla.org/mozilla-central/rev/b56027688b72
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.