995655 - Fix -Wpointer-sign and -Wuinitialized warnings in libmar

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-Wuninitialized-warnings.patch

If mar_sign.c's import_signature() returns early, it can call fclose() on uninitialized FILE* local variables fpSrc, fpDest, and fpSigFile.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: fix-Wpointer-sign-warnings.patch

Fix -Wpointer-sign warnings in mar_read.c

modules/libmar/src/mar_read.c:564:29 [-Wpointer-sign] passing 'uint32_t *' (aka 'unsigned int *') to parameter of type 'int *' converts between pointers to integer types with different sign
modules/libmar/src/mar_read.c:565:29 [-Wpointer-sign] passing 'uint32_t *' (aka 'unsigned int *') to parameter of type 'int *' converts between pointers to integer types with different sign
modules/libmar/src/mar_read.c:565:53 [-Wpointer-sign] passing 'uint32_t *' (aka 'unsigned int *') to parameter of type 'int *' converts between pointers to integer types with different sign

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 8405793 [details] [diff] [review]
fix-Wpointer-sign-warnings.patch

Thanks!

Comment 3

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b16eeaaf966
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4806a83b2bd

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8b16eeaaf966
https://hg.mozilla.org/mozilla-central/rev/d4806a83b2bd