Move CSSRuleList to WebIDL

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks 1 bug)

Trunk
mozilla32
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Got a patch.
Assignee

Comment 1

5 years ago
Posted patch Patch v1Splinter Review
Attachment #8405873 - Flags: review?(bzbarsky)
Comment on attachment 8405873 [details] [diff] [review]
Patch v1

>+    'nsICSSRuleList.cpp', # TODO: move to unified

Please document the reason it's not, like the other ones are documented.

And maybe a followup to rename nsICSSRuleList to mozilla::dom::CSSRuleList?

r=me
Attachment #8405873 - Flags: review?(bzbarsky) → review+
And thank you for getting rid of all that code!
Assignee

Updated

5 years ago
Depends on: 995901
Assignee

Comment 4

5 years ago
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 8405873 [details] [diff] [review]
> Patch v1
> 
> >+    'nsICSSRuleList.cpp', # TODO: move to unified
> 
> Please document the reason it's not, like the other ones are documented.

The reason it's not is because I wanted to check that I got all the includes I needed; I'll move it into unified_sources before landing.

> And maybe a followup to rename nsICSSRuleList to mozilla::dom::CSSRuleList?

bug 995664

(In reply to Boris Zbarsky [:bz] from comment #3)
> And thank you for getting rid of all that code!

My pleasure!
> bug 995664

That's this bug.  ;)
Assignee

Comment 6

5 years ago
(In reply to Boris Zbarsky [:bz] from comment #5)
> > bug 995664
> 
> That's this bug.  ;)

Ahem. Bug 995901.
https://hg.mozilla.org/mozilla-central/rev/cc42442f4728
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.