Closed
Bug 995664
Opened 10 years ago
Closed 10 years ago
Move CSSRuleList to WebIDL
Categories
(Core :: DOM: CSS Object Model, defect)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
21.21 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Got a patch.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8405873 -
Flags: review?(bzbarsky)
Comment 2•10 years ago
|
||
Comment on attachment 8405873 [details] [diff] [review] Patch v1 >+ 'nsICSSRuleList.cpp', # TODO: move to unified Please document the reason it's not, like the other ones are documented. And maybe a followup to rename nsICSSRuleList to mozilla::dom::CSSRuleList? r=me
Attachment #8405873 -
Flags: review?(bzbarsky) → review+
Comment 3•10 years ago
|
||
And thank you for getting rid of all that code!
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #2) > Comment on attachment 8405873 [details] [diff] [review] > Patch v1 > > >+ 'nsICSSRuleList.cpp', # TODO: move to unified > > Please document the reason it's not, like the other ones are documented. The reason it's not is because I wanted to check that I got all the includes I needed; I'll move it into unified_sources before landing. > And maybe a followup to rename nsICSSRuleList to mozilla::dom::CSSRuleList? bug 995664 (In reply to Boris Zbarsky [:bz] from comment #3) > And thank you for getting rid of all that code! My pleasure!
Comment 5•10 years ago
|
||
> bug 995664
That's this bug. ;)
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #5) > > bug 995664 > > That's this bug. ;) Ahem. Bug 995901.
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc42442f4728
Flags: in-testsuite-
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cc42442f4728
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•