Closed Bug 995687 Opened 10 years ago Closed 10 years ago

Intermittent system/test/unit/icc_test.js | STK (icc) > getIccInfo | Error: expected null to equal 'http://www.mozilla.org/en-US/firefoxos/' | STK (icc) > "after each" hook | TypeError: DUMP is not a function

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED FIXED
Milestone:
2.1 S6 (10oct)
Project Flags:
tracking-b2g backlog

People

(Reporter: RyanVM, Assigned: kgrandon)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=37664993&tree=B2g-Inbound

b2g_ubuntu64_vm b2g-inbound opt test gaia-unit on 2014-04-11 16:41:51 PDT for push b25c8c53c8bc
slave: tst-linux64-spot-084

17:11:15     INFO -  gaia-unit-tests TEST-START | system/test/unit/icc_test.js |
17:11:15     INFO -  gaia-unit-tests TEST-START | system/test/unit/icc_test.js | STK (icc) >
17:11:15     INFO -  gaia-unit-tests TEST-PASS  | system/test/unit/icc_test.js | STK (icc) > getIcc
17:11:16     INFO -  JavaScript error: http://system.gaiamobile.org:8080/common/test/helper.js?time=1397261475227, line 33: expected null to equal 'http://www.mozilla.org/en-US/firefoxos/'
17:11:16     INFO -  gaia-unit-tests TEST-UNEXPECTED-FAIL | system/test/unit/icc_test.js | STK (icc) > getIccInfo | Error: expected null to equal 'http://www.mozilla.org/en-US/firefoxos/' (http://system.gaiamobile.org:8080/common/test/helper.js?time=1397261475227:33)
17:11:16     INFO -  gaia-unit-tests INFO       | stack trace:
17:11:16     INFO -      Error: Error: expected null to equal 'http://www.mozilla.org/en-US/firefoxos/' (http://system.gaiamobile.org:8080/common/test/helper.js?time=1397261475227:33)
17:11:16     INFO -          at onerror (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:7)
17:11:16     INFO -  JavaScript error: http://system.gaiamobile.org:8080/js/icc.js?time=1397261475852, line 74: DUMP is not a function
17:11:16     INFO -  gaia-unit-tests TEST-UNEXPECTED-FAIL | system/test/unit/icc_test.js | STK (icc) > "after each" hook | TypeError: DUMP is not a function (http://system.gaiamobile.org:8080/js/icc.js?time=1397261475852:74)
17:11:16     INFO -  gaia-unit-tests INFO       | stack trace:
17:11:16     INFO -      Error: TypeError: DUMP is not a function (http://system.gaiamobile.org:8080/js/icc.js?time=1397261475852:74)
17:11:16     INFO -          at onerror (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:7)
Put this bug into backlog.
blocking-b2g: --- → backlog
I think that this happening on many tests that leverage the "mock_dump" file. Taking.
Assignee: nobody → kgrandon
Blocks: 1076681
Status: NEW → ASSIGNED
Component: RIL → Gaia
Target Milestone: --- → 2.1 S6 (10oct)
Attached file Github pull request — 
Julien - could you review this for me being that you are a unit test expert? I think what's happening is that we have many tests which rely on DUMP and call it asynchronously. I think moving this into suite setup/teardown should help things.
Attachment #8502773 - Flags: review?(felash)
Kevin, do you have a recent failure log that you could share?
(In reply to Julien Wajsberg [:julienw] from comment #24)
> Kevin, do you have a recent failure log that you could share?

I'll try to find it, but it was the exact same thing from TBPL robot, gaia-unit-tests TEST-UNEXPECTED-FAIL | system/test/unit/icc_test.js | STK (icc) > "after each" hook | TypeError: DUMP is not a function (http://system.gaiamobile.org:8080/js/icc.js?time=1402395809362:74)
Return code: 10
But in each error report, there's also another error before. Do you think this will fix it as well?
I can't find any failure with this. So I'm basically fine with landing what you suggest as this is a good thing and we'll see.
Comment on attachment 8502773 [details] [review]
Github pull request

r=me
Attachment #8502773 - Flags: review?(felash) → review+
(In reply to Julien Wajsberg [:julienw] from comment #27)
> I can't find any failure with this. So I'm basically fine with landing what
> you suggest as this is a good thing and we'll see.

Thanks Julien. Sorry I've been slammed with blockers and haven't tried to locate a recent failure. I'm pretty sure that this is still failing though!
In master: https://github.com/mozilla-b2g/gaia/commit/32382813debb968645242db16e062ca223b63b26
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1109925
No longer blocks: 1076681
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: