Closed Bug 995781 Opened 10 years ago Closed 10 years ago

Profile img is not in a perfect circle.

Categories

(Webmaker Graveyard :: X-Ray Goggles, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: admix, Assigned: admix)

Details

Attachments

(2 files)

While I was fixing aligning for goggle navigation, profile img changed it shape a little bit. It should be a circle.
Assignee: nobody → admix.snurnikov
Hamabama directed me on this issue. As it was my miss, when I was fixing alignment, I took it and fixed.
Attachment #8405888 - Flags: review?(pomax)
Comment on attachment 8405888 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/128

for the publish dialog, with your fix in it looks right, but then everything's 10px too low:

your fix: http://imgur.com/xlO8bMr
hack-corrected: http://imgur.com/0fjr60K

so we probably need to fix this slightly differently, making sure that the additional padding from the main page does not leak into the publish dialog.
Attachment #8405888 - Flags: review?(pomax) → review-
Comment on attachment 8405888 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/128

Fixed that dialog window part. Also, aligned "Sign In" button with "Close" in dialog window.
Attachment #8405888 - Flags: review- → review?(pomax)
Commit pushed to master at https://github.com/mozilla/goggles.webmaker.org

https://github.com/mozilla/goggles.webmaker.org/commit/4b2d09f64e466dc3860584f78d8085191f5cfecd
Fix [bug995781] - Fixed profile img shape, when logged in. Aligned user-info area inside dialog window
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: