Open Bug 995891 Opened 6 years ago Updated 1 year ago

Reduce stub installer install timeouts

Categories

(Firefox :: Installer, enhancement, P3)

x86_64
Windows 8.1
enhancement

Tracking

()

Firefox 31

People

(Reporter: robert.strong.bugs, Unassigned)

Details

(Whiteboard: [leave open][stubv3+])

Attachments

(2 files, 1 obsolete file)

Approximately 1.5% of stub installer installs timeout during the install phase. We currently attempt to install for about 2 minutes (2 and a half minutes for Firefox 30) which is clearly not long enough for all cases. Also, we can't just extend the time due to not having anything to identify progress from the full installer to the stub installer.

I propose the following changes to fix this:

1. add a new 7-zip self-extracting archive command line option to specify the directory to extract to (I am fairly certain our current version doesn't have one).

2. extract the 7-zip self-extracting archive to a sub-directory of the install directory instead of launching it to install. These should be file moves so it will be fast since they should be on the same partition.

3. let the stub installer perform the installation of the files which is likely where the operations are timing out and launch the installer setup program to perform all of the other operations. It is necessary to launch the installer setup program since it will be the latest and greatest operations whereas the stub installer can be stale in that it won't necessarily contain all of the registry key adds, mods, deletes, shortcut changes, etc. This will also keep the stub installer size from increasing significantly.
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Whiteboard: [stubv2=] → [stubv2+]
Comment on attachment 8406380 [details] [diff] [review]
7-Zip self-extracting archive patch

Hey Tim, I'd like to get this landed before the remaining work so when I land the changes to the stub installer the downloaded full installer already has these changes. The newlines are not our usual format due to my wanting to keep them the same as the original source.
Attachment #8406380 - Flags: review?(tabraldes)
Comment on attachment 8406380 [details] [diff] [review]
7-Zip self-extracting archive patch

Review of attachment 8406380 [details] [diff] [review]:
-----------------------------------------------------------------

Seems pretty straightforward
Attachment #8406380 - Flags: review?(tabraldes) → review+
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/65238e923500
https://hg.mozilla.org/integration/fx-team/rev/6608fb641776
Flags: in-testsuite-
Whiteboard: [stubv2+] → [leave open][stubv2+]
Target Milestone: --- → Firefox 31
Whiteboard: [leave open][stubv2+] → [leave open][stubv3+]
Assignee: robert.strong.bugs → nobody
Status: ASSIGNED → NEW
As an update, 1.1% of stub installer installs end-up with an install_timeout error per https://sql.telemetry.mozilla.org/queries/20023/source#51261
When looking at the install_time distribution a significant number of installs take over 120s: https://sql.telemetry.mozilla.org/queries/3675/source#7270
Matt, can you please confirm the how the stub handles install_timeout currently (if install_time is over 120s do we throw install_timeout?).
Flags: needinfo?(mhowell)
The timeout is 150 seconds for a new install and 165 seconds for a paveover (because there are additional steps for deleting files). It would be concerning if a lot of installs were falling into the range between 120 and those thresholds, but I don't see that happening in very many cases.
Flags: needinfo?(mhowell)
Priority: -- → P3
Type: defect → enhancement
You need to log in before you can comment on or make changes to this bug.