Closed Bug 995922 Opened 6 years ago Closed 6 years ago

Remove JOHAB support

Categories

(Core :: Internationalization, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

(Whiteboard: [MemShrink:P3])

Attachments

(1 file, 1 obsolete file)

As far as I can tell, the only place where we use our JOHAB code in Firefox these days is at
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxFontUtils.cpp#1225
for decoding legacy font names.

Telemetry suggests that no one actually uses fonts like that:
http://telemetry.mozilla.org/#release/28/DECODER_INSTANTIATED_JOHAB/saved_session/Firefox

Since we already don't support the full set of legacy encodings for font names, I suggest we remove JOHAB support from the tree.

jfkthame, are you OK with this?
Flags: needinfo?(jfkthame)
I'm OK with this from the font-name-encoding point of view; cc'ing jdaggett to make sure he's also aware of it and can speak up in case of any concerns.

What encoding gets used for web content that is tagged as charset=x-johab? What is used by the View / Character Encoding / Korean option?

In any case, given the current discussion about the position of c-c in relation to m-c, perhaps it'd be better not to rush the actual removal of support if there's a possibility that email-related code is using it.
Flags: needinfo?(jfkthame)
(In reply to Jonathan Kew (:jfkthame) from comment #1)
> What encoding gets used for web content that is tagged as charset=x-johab?

Already the same encoding as for content tagged charset=foobar-invalid. I.e. depends on the TLD of the site or on the browser configuration with localization-dependent defaults.

> What is used by the View / Character Encoding / Korean option?

EUC-KR.

> In any case, given the current discussion about the position of c-c in
> relation to m-c, perhaps it'd be better not to rush the actual removal of
> support if there's a possibility that email-related code is using it.

I'm thinking of fixing bug 937056 first to give c-c some infrastructure for moving stuff over. Once the infrastructure for c-c to receive converters exists, I think it's up to Thunderbird devs to pick up the removed encodings, though.
Whiteboard: [MemShrink] → [MemShrink:P3]
Attached patch WIP (obsolete) — Splinter Review
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #8419996 - Flags: review?(VYV03354)
Comment on attachment 8419996 [details] [diff] [review]
Remove JOHAB

Yay!
Attachment #8419996 - Flags: review?(VYV03354) → review+
Blocks: 1008845
https://hg.mozilla.org/mozilla-central/rev/b5eef7023c52
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.