Closed
Bug 995954
Opened 10 years ago
Closed 10 years ago
Invalid JSON file : apps/homescreen/everything.me/config/local.json
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: daleharvey, Assigned: daleharvey)
References
Details
(Whiteboard: [systemsfe][p=1])
Attachments
(1 file)
This is wrapped around a try catch and logs an error when local.json doesnt exist, it shouldnt log an error (as people may consider that the reason their profile wont build and start debugging despite it being expected)
|
Assignee | |
Updated•10 years ago
|
Blocks: dale-being-happy
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [systemsfe][p=1]
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → dale
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8415225 -
Flags: review?(yurenju.mozilla)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8415225 [details] [review] https://github.com/mozilla-b2g/gaia/pull/18830 looks good.
Attachment #8415225 -
Flags: review?(yurenju.mozilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks yuren https://github.com/mozilla-b2g/gaia/commit/1e42ad6f307f69ad269dd5baba935cd7fc82b703
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•