995992 - New screen has been added to the FTU ui

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Florin Strugariu [:Bebe]]

Description:
New screen has been added to the FTU UI it looks like we are missing a step in our tests. let;'s add it to our tests 

There is no valid bug for this issue just a enhancement in our tests  


Environment:
Gaia      f3abbd2d0a60f1a1618db93f8b1957cae6de379c
Gecko     https://hg.mozilla.org/mozilla-central/rev/215080b813a7
BuildID   20140414040203
Version   31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013


Traceback (most recent call last):
06:04:09 TEST-START test_ftu_skip_tour.py
06:04:10 test_ftu_skip_tour (test_ftu_skip_tour.TestFtu)
06:06:03 https://moztrap.mozilla.org/manage/case/3876/ ... ERROR
06:06:03 
06:06:03 ======================================================================
06:06:03 ERROR: None
06:06:03 ----------------------------------------------------------------------
06:06:03 Traceback (most recent call last):
06:06:03   File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
06:06:03     testMethod()
06:06:03   File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_skip_tour.py", line 86, in test_ftu_skip_tour
06:06:03     self.ftu.tap_next_to_welcome_browser_section()
06:06:03   File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/apps/ftu/app.py", line 175, in tap_next_to_welcome_browser_section
06:06:03     self.wait_for_element_displayed(*self._section_welcome_browser_locator)
06:06:03   File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 42, in wait_for_element_displayed
06:06:03     lambda m: m.find_element(by, locator).is_displayed())
06:06:03   File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 143, in until
06:06:03     cause=last_exc)
06:06:03 TimeoutException: TimeoutException: Timed out after 30.0708870888 seconds
06:06:03 TEST-UNEXPECTED-FAIL | test_ftu_skip_tour.py test_ftu_skip_tour.TestFtu.test_ftu_skip_tour | 
06:06:03 ----------------------------------------------------------------------
06:06:03 Ran 1 test in 112.742s
06:06:03 
06:06:03 FAILED (errors=1)

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/18320

Comment 2

[Viorela Ioia [:viorela]]

In the pull above I added a method where we tap next to the new section(firefox accounts). Should we also create an account when we get to this step? If we do, then I will update the PR.

Comment 3

[Florin Strugariu [:Bebe]]

Zac JSmith  can you help Viorela pls

Comment 4

[Zac C (:zac)]

(In reply to Viorela Ioia [:viorela] from comment #2)
> In the pull above I added a method where we tap next to the new
> section(firefox accounts). Should we also create an account when we get to
> this step? If we do, then I will update the PR.

No don't worry about that, just interacting with the FTU is enough.

Comment 5

[Zac C (:zac)]

Also I am wondering why Travis didn't pick this up, specifically the test you wrote for FTU on desktopb2g Viorela?
Can you check on desktopb2g why it did not fail?

Comment 6

[Viorela Ioia [:viorela]]

Test_ftu_skip_tour_desktopb2g.py is currently xfailed because of Bug 976570

Comment 7

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/1befe1cf43fd2397844312ed679c5925fbf81be0