Closed
Bug 996003
Opened 10 years ago
Closed 10 years ago
Cleanup devtools mochitest manifests
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: RyanVM, Assigned: RyanVM)
Details
Attachments
(1 file, 1 obsolete file)
34.00 KB,
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
A few of the manifests are missing the devtools subsuite annotations and others are missing the e10s skip-ifs. I'll clean them up and run them through Try.
Assignee | ||
Comment 1•10 years ago
|
||
Adds some missing annotations and uses more consistent style in the headers. Going to run this through Try before requesting review.
Assignee | ||
Comment 2•10 years ago
|
||
I'm also going to file another bug for maybe finding a better way to annotate the subsuites so we don't have to worry about new manifests getting the right annotations when added.
Assignee | ||
Comment 3•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=aac0b3fd70d8
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8406188 [details] [diff] [review] patch Whoops, this one inadvertently re-enables the profiler tests.
Attachment #8406188 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
OK, leaving the global skip-if below the e10s skip-if for the profiler tests. I also did some cleanup of the moz.build files. Pointing to the manifest from one directory level up saves us some recursion during the build, which can help perf-wise. https://tbpl.mozilla.org/?tree=Try&rev=784d598aaf16
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8406405 [details] [diff] [review] patch Looks good on Try and it definitely helps balance out chunk runtimes a bit.
Attachment #8406405 -
Flags: review?(mratcliffe)
Updated•10 years ago
|
Attachment #8406405 -
Flags: review?(mratcliffe) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4ac11d68cea3
Flags: in-testsuite-
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4ac11d68cea3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•