Closed Bug 996003 Opened 10 years ago Closed 10 years ago

Cleanup devtools mochitest manifests

Categories

(DevTools :: General, defect)

26 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: RyanVM, Assigned: RyanVM)

Details

Attachments

(1 file, 1 obsolete file)

A few of the manifests are missing the devtools subsuite annotations and others are missing the e10s skip-ifs. I'll clean them up and run them through Try.
Attached patch patch (obsolete) — Splinter Review
Adds some missing annotations and uses more consistent style in the headers. Going to run this through Try before requesting review.
I'm also going to file another bug for maybe finding a better way to annotate the subsuites so we don't have to worry about new manifests getting the right annotations when added.
Comment on attachment 8406188 [details] [diff] [review]
patch

Whoops, this one inadvertently re-enables the profiler tests.
Attachment #8406188 - Attachment is obsolete: true
Attached patch patchSplinter Review
OK, leaving the global skip-if below the e10s skip-if for the profiler tests. I also did some cleanup of the moz.build files. Pointing to the manifest from one directory level up saves us some recursion during the build, which can help perf-wise.

https://tbpl.mozilla.org/?tree=Try&rev=784d598aaf16
Comment on attachment 8406405 [details] [diff] [review]
patch

Looks good on Try and it definitely helps balance out chunk runtimes a bit.
Attachment #8406405 - Flags: review?(mratcliffe)
Attachment #8406405 - Flags: review?(mratcliffe) → review+
https://hg.mozilla.org/integration/fx-team/rev/4ac11d68cea3
Flags: in-testsuite-
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4ac11d68cea3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: