Closed Bug 996052 Opened 5 years ago Closed 5 years ago

Remove JSVAL_TRACE_KIND, JSVAL_IS_GCTHING and JSVAL_TO_GCTHING

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: jonco, Assigned: jonco)

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(1 file)

JSVAL_TRACE_KIND(v) currently asserts JSVAL_IS_GCTHING(v) which returns true for null JSObject* values.  It should probably have been JSVAL_IS_TRACEABLE(v).

However it doesn't seem to be called anywhere, so we just remove it.

Also, the few uses of JSVAL_IS_TRACEABLE() can be replaced with Value::isMarkable() and those of JSVAL_TO_GCTHING() can be replaced with Value::toGCThing().
Assignee: nobody → jcoppeard
Attachment #8407445 - Flags: review?(terrence)
Might want to wait with this until we cut 31esr
Comment on attachment 8407445 [details] [diff] [review]
bug996052-removeTraceMacros

Review of attachment 8407445 [details] [diff] [review]:
-----------------------------------------------------------------

r=me Ironically, I was just about to write this patch when I checked my review queue.

(In reply to :Ms2ger from comment #2)
> Might want to wait with this until we cut 31esr

Potentially. There is a straightforward replacement for the removed functions, however, so I don't think it's a big deal either way.
Attachment #8407445 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/735fb8486e8e
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.