Closed
Bug 996052
Opened 10 years ago
Closed 10 years ago
Remove JSVAL_TRACE_KIND, JSVAL_IS_GCTHING and JSVAL_TO_GCTHING
Categories
(Core :: JavaScript: GC, enhancement)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: jonco, Assigned: jonco)
Details
(Keywords: addon-compat)
Attachments
(1 file)
6.70 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
JSVAL_TRACE_KIND(v) currently asserts JSVAL_IS_GCTHING(v) which returns true for null JSObject* values. It should probably have been JSVAL_IS_TRACEABLE(v). However it doesn't seem to be called anywhere, so we just remove it. Also, the few uses of JSVAL_IS_TRACEABLE() can be replaced with Value::isMarkable() and those of JSVAL_TO_GCTHING() can be replaced with Value::toGCThing().
Assignee | ||
Comment 1•10 years ago
|
||
Assignee: nobody → jcoppeard
Attachment #8407445 -
Flags: review?(terrence)
Comment 2•10 years ago
|
||
Might want to wait with this until we cut 31esr
Comment 3•10 years ago
|
||
Comment on attachment 8407445 [details] [diff] [review] bug996052-removeTraceMacros Review of attachment 8407445 [details] [diff] [review]: ----------------------------------------------------------------- r=me Ironically, I was just about to write this patch when I checked my review queue. (In reply to :Ms2ger from comment #2) > Might want to wait with this until we cut 31esr Potentially. There is a straightforward replacement for the removed functions, however, so I don't think it's a big deal either way.
Attachment #8407445 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/735fb8486e8e
Updated•10 years ago
|
Keywords: addon-compat,
dev-doc-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/735fb8486e8e
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Updated•4 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•