996112 - [B2G][Gaia][Gallery]Zooming into many images will result in an OOM close

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P1)

Description

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: zoom_oom_log.txt

Description:
Zooming in and then switching to another image many times will result in an OOM close of the gallery.

Repro Steps:
1) Update a Buri to BuildID: 20140414000201
2) Get at least two images on the device (the camera is suggested)
3) Enter the Galery and select the image
4) Double tap the image to zoom it
5) Swipe to another image
6) Repeat steps 4 and 5 until the app runs OOM and closes

Actual:
The Gallery closes because it is OOM

Expected:
The gallery does not close.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140414000201
Gaia: 8dff633372022723e2ebad17fe3c826436b3b258
Gecko: bc14179fc49c
Version: 30.0a2
Firmware Version: v1.2-device.cfg


Notes:

Repro frequency: 100%
See attached: logcat, video, about-memory report

Comment 1

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

On Buri 1.3 this does not occur.

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140402164004
Gaia: c5cd3a11e91339163b351d50769eaca0067da860
Gecko: c6c7b01cdb8e
Version: 28.0
Firmware Version: v1.2-device.cfg


On 3/26 Buri 1.4 this occurs.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140326000201
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Gecko: 4889124accfa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: about-memory-5.zip

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Please see this video
https://www.youtube.com/watch?v=E52d2-PgK1g&feature=youtu.be

Comment 5

[Hema Koka [:hema]]

blocking based on regression from 1.3 (comment 1)

Comment 6

[Kai-Chih Hu [:khu]]

(In reply to Hema Koka [:hema] from comment #5)
> blocking based on regression from 1.3 (comment 1)

Hi, Hema, can you help to find someone to help this bug? Thanks.

Comment 7

[Hema Koka [:hema]]

Yes, we are looking into the 1.4 blockers and this is in the radar, once other blockers are fixed, camera folks will jump on this next.

Thanks!

Comment 8

[Hema Koka [:hema]]

After tarako image rotation bug, please take a look at this one.

Thanks
Hema

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat.txt

This bug still occurs even after the LMK patch backout by the vendor:
1) launch camera
2) switch to gallery
3) while items are loading, select an image
4) double tap on the image.

OOM killed.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Gaia      5a5690d6691d3bc23e83d4433b458192f4197a8f
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/69214e49e489
BuildID   20140416164002
Version   28.1
ro.build.version.incremental=eng.cltbld.20140416.203531
ro.build.date=Wed Apr 16 20:35:38 EDT 2014
Tarako

Question : would disabling zoom feature on gallery images be feasible?

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment 9 & 10 was meant for 1.3t branch only.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #11)
> Comment 9 & 10 was meant for 1.3t branch only.

We might want to open a separate bug for Tarako here, as I'm betting the solution required here for Tarako is going to be different than this bug.

Comment 13

[David Flanagan [:djf]]

I'm really curious to see the regression window on this one.

The logcat shows a lot of pmem, ashmem stuff. I don't have any clue about that, but it makes me think that this could be related to graphics changes in gecko.

Setting needinfo for QA for this question: I'm also curious to know whether the OOM is time-sensitive. When you double-tap on an image, it zooms right away, but is blurry for a second or two until the full-size image is swapped in. If you double-tap and then wait until the zoomed image becomes crisp, and then swipe, can you still reproduce the bug?

If this bug only happens if you swipe during the "zoomed but blurry" state, then it is likely that the bug is in gaia and I'm just not properly freeing image memory when the swipe happens in this state.

Comment 14

[Natalya Kot [:nkot]]

(In reply to David Flanagan [:djf] from comment #13)
> I'm really curious to see the regression window on this one.
> 
 
our QA is working on regression-window here, should post it shortly

Comment 15

[Harvey]

Providing the Tinderbox window for now, still working on B2G Inbound. 

The repro rate on this issue seems to drop quite a bit in earlier builds (~5%).

Last Working Environmental Variables: 
Device: Buri 
BuildID: 20140307074856
Gaia: b3758a90b8888e9d95128846b2833b4d9444ef7f
Gecko: 7a2edc5171e6
Version: 30.0a1
Firmware Version: v1.2-device.cfg

First Broken Environmental Variables: 
Device: Buri
BuildID: 20140307123330
Gaia: 6c109df47006b08c082761c0ddd6ba53a864983a
Gecko: 99e60b1adf71
Version: 30.0a1
Base Image: V1.2-device.cfg

Last Working Gaia First Broken Gecko: Issue DOES reproduce
Gaia: b3758a90b8888e9d95128846b2833b4d9444ef7f
Gecko: 99e60b1adf71

First Broken Gaia Last Working Gecko: Issue does NOT reproduce
Gaia: 6c109df47006b08c082761c0ddd6ba53a864983a
Gecko: 7a2edc5171e6

Gecko Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7a2edc5171e6&tochange=99e60b1adf71

Comment 16

[Harvey]

B2G Inbound Regression Window

Last Working Environmental Variables: 
Device: Buri
BuildID: 20140307075356
Gaia: 5de5cab90e1a83d81c0fc506912696d85b1865fe
Gecko: 744810b79570
Version: 30.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri 
BuildID: 20140307081757
Gaia: 5de5cab90e1a83d81c0fc506912696d85b1865fe
Gecko: 2429468e82dd
Version: 30.0a1
Firmware Version: v1.2-device.cfg

The Gaia is the same on both builds indicating that this is a Gecko issue.

Gecko Pushlog: http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=744810b79570&tochange=2429468e82dd

Note: The issue does seem to be made easier to reproduce by zooming in and changing photos rapidly.

Comment 17

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #12)
> (In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from
> comment #11)
> > Comment 9 & 10 was meant for 1.3t branch only.
> 
> We might want to open a separate bug for Tarako here, as I'm betting the
> solution required here for Tarako is going to be different than this bug.

Looks like I'm wrong. This was caused by bug 962670, which is a regression from a patch that landed on 1.3T & 1.4.

Comment 18

[bhavana bajaj [:bajaj]]

(In reply to Jason Smith [:jsmith] from comment #17)
> (In reply to Jason Smith [:jsmith] from comment #12)
> > (In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from
> > comment #11)
> > > Comment 9 & 10 was meant for 1.3t branch only.
> > 
> > We might want to open a separate bug for Tarako here, as I'm betting the
> > solution required here for Tarako is going to be different than this bug.
> 
> Looks like I'm wrong. This was caused by bug 962670, which is a regression
> from a patch that landed on 1.3T & 1.4.

NI :mwu on next steps here as this is indicated to be a fallout from 962670

Comment 19

[Joe Cheng [:jcheng] (please needinfo)]

triage: regression, 1.3T+

Comment 20

[Nicholas Nethercote [inactive]]

mwu, are there plans to back out bug 962670?

Comment 21

[Michael Wu [:mwu]]

(In reply to Nicholas Nethercote [:njn] from comment #20)
> mwu, are there plans to back out bug 962670?

It's been disabled on 1.4 and master. Going to land a disabling patch for Tarako too.

Comment 22

[Michael Wu [:mwu]]

See bug 996226 for the patch that disables it.

Comment 23

[Michael Wu [:mwu]]

Resolved on 1.3t using the patch from bug 996226 .

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/884ddde65b59

Comment 24

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Fixed on todays 1.3T build.

1.3T Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140428014001
Gaia: 8895b180ed636069473703d0e7b73086989601ce
Gecko: 7caf4b5abfce
Version: 28.1
Firmware Version: sp6821

Zooming into a large number of images did not crash the device.

Comment 25

[David Flanagan [:djf]]

Bulk edit to clear old and out of date needinfo requests that I never responded to. I'm assuming that these are no longer relevant. If you are still waiting for an answer from me, please set needinfo? again.