996186 - Main window briefly shows flat background color during customize mode transition

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

This is fallout from bug 973694 - we're temporarily showing the old private browsing mode flat colour during the customize mode transition.

Looks like ass. Patch coming up.

Comment 1

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Patch v1

Should have caught this the first time around.

Basically, we set the -moz-appearance of the #titlebar to none in order to make so that we can apply a nice textured background to it (the grid) in customize mode. We only need to do that on customize-entered, since this is when the grid is applied. Before then, we should keep the titlebar around.

We can discount LWT's, because during the transition, LWT's have been unapplied.

Requesting review from either Gijs or MattN. I'll let you two duke it out.

Comment 2

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

This doesn't break anything functionally speaking, but it certainly detracts from the smoothness of the transition, which I think we'd like to preserve if at all possible.

Comment 3

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Comment on attachment 8406382 [details] [diff] [review]
Patch v1

That's an empty patch. *sigh*, qref. Brb.

Comment 4

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Attachment: Patch v1.1

Here we are.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8406389 [details] [diff] [review]
Patch v1.1

Review of attachment 8406389 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, but let's either trypush or monitor fx-team/m-c carefully as we land this to check CART does OK.

Comment 6

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Since we're essentially going back to the same behaviour as before, I'm not too too worried about CART, but I'll keep my eye on it.

Thanks!

remote:   https://hg.mozilla.org/integration/fx-team/rev/bba21dfbd381

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bba21dfbd381

Comment 8

[Mike Conley (:mconley) (:⚙️) (Catching up on needinfos)]

Comment on attachment 8406389 [details] [diff] [review]
Patch v1.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Fallout from a badly selected attribute in a CSS rule from bug 973694.


User impact if declined: 

A rather unpleasant flash of a flat background colour on the titlebar during the middle of the customize mode transition.


Testing completed (on m-c, etc.): 

Local testing.


Risk to taking this patch (and alternatives if risky): 

Extremely low - CSS only, and very much isolated to just the customize mode transition.


String or IDL/UUID changes made by this patch:

None.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8406389 [details] [diff] [review]
Patch v1.1

Approving because it is a low risk and a tiny patch (and also because Australis matters)

Comment 10

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/rev/caf2147c04f4
https://hg.mozilla.org/releases/mozilla-aurora/rev/966c5e593046

Comment 11

[Ioana (away)]

This was fixed for normal mode, but not for fullscreen mode.

Verified as fixed on Mac OS X 10.9.2 using Firefox 29.0b9 and the 04/17 Aurora and Nightly.
Filed bug 998275 for fullscreen.