Closed Bug 996195 Opened 10 years ago Closed 10 years ago

[Camera][Madai][UX] Mode Switcher Icons should have the same size on both on and off states

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dmarcos, Assigned: dmarcos)

References

Details

Attachments

(3 files)

switchModeVideo.png
465.47 KB, image/png
Details
switchModePhoto.png
370.37 KB, image/png
Details
Pull Request
46 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review
Attached image switchModeVideo.png — 
The icons of the mode switcher are smaller on selected state than on unselected state. It feels inconsistent (see attached pictures) 

When the switcher slides over the new selected mode (video or picture) the selected icon should overlap perfectly over the unselected one.
Blocks: 983405
Attached image switchModePhoto.png — 

    
  
Summary: [Camera][Madai] Mode Switcher Icons should have the same size on both on and off states → [Camera][Madai][UX] Mode Switcher Icons should have the same size on both on and off states

    
  
Assignee: nobody → dmarcos

    
    

    
  

      
      
      
      

        Attached file
          
        Pull Request
        — 
      

    


  

    
  

        Attachment #8408359 -
        Flags: review?(jdarcangelo)

        Attachment #8408359 -
        Flags: review?(jdarcangelo) → review+

    
    

    
  
Landed in master:

https://github.com/dmarcos/gaia/commit/d33622ad64e65fd23f1583c2fcd68b1cb199ef3f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: