996228 - Schematic: use MySQL-python instead of forking mysql subprocesses

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[Jeremy Orem [:oremj]]

Right now, schematic runs "mysql -u foo -ppass -h db_host db_name". In MySQL 5.6, -p throws a warning and breaks schematic. We need to use MySQL-python instead of avoid the errors.

Comment 1

[Wil Clouser [:clouserw]]

Hi Yohan - would you look at this?  Most of our projects use this MySQL-python (https://github.com/mozilla/funfactory/blob/master/funfactory/requirements/compiled.txt#L1).  Docs are at http://mysql-python.sourceforge.net/MySQLdb.html .  https://github.com/mozilla/schematic/blob/master/schematic#L147 is where the sql is exec'd.

Thanks!

Comment 2

[Andy McKay]

Longer term, we should move to South or Django 1.7, as per bug 905785.

Comment 3

[Yohan Boniface [:ybon]]

I don't think this will be a problem, given the situation of schematic (old and unmaintained, plus untested), but just to make it explicit: I'm going to make schematic MySQL specific, even though it's not really the case now. Please stop me if this is not wanted.

Comment 4

[Jeremy Orem [:oremj]]

That's a good point. Alternatively, we could change:
if config['PASSWORD']:
    s += ' -p{PASSWORD}'
to:
os.environ['MYSQL_PWD'] = config['PASSWORD']

in schematic settings.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to Jeremy Orem [:oremj] from comment #4)
> That's a good point. Alternatively, we could change:
> if config['PASSWORD']:
>     s += ' -p{PASSWORD}'
> to:
> os.environ['MYSQL_PWD'] = config['PASSWORD']
> 
> in schematic settings.

That seems super easy.  Let's just do that..

Comment 6

[Jeremy Orem [:oremj]]

https://github.com/mozilla/zamboni/pull/1944

Comment 7

[Yohan Boniface [:ybon]]

@oremj are you pushing to olympia too?

Comment 8

[Jeremy Orem [:oremj]]

Sure, I think solitude and webpay need it as well. Anything else?

Comment 9

[Jeremy Orem [:oremj]]

https://github.com/mozilla/webpay/pull/427

Comment 10

[Jeremy Orem [:oremj]]

https://github.com/mozilla/solitude/pull/215

Comment 11

[Jeremy Orem [:oremj]]

https://github.com/mozilla/olympia/pull/40