Closed Bug 996243 Opened 7 years ago Closed 2 years ago

Accessibility Review for FxA Sync

Categories

(Firefox :: Sync, enhancement)

Product:
Firefox
Component:
Sync
Version:
29 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: kthiessen, Unassigned)

References

Details

I am unable to determine whether we have had any accessibility review of the new UI flows for Firefox Accounts/Sync.  I am cc'ing the relevant folks in hopes that if the review has already been done, they can mark this bug a dupe, and if it hasn't been done, that they can expedite it.
QA Contact: kthiessen
Ryan, do you know if there's been any accessibility work done around FxA/Sync?
Flags: needinfo?(rfeeley)
:rnewman, do you know what sort of accessibility review Legacy Sync went through?  And whether FxA has done anything similar?
Flags: needinfo?(rnewman)
To the best of my knowledge, we haven't had any such review. I'm low on cycles right now, but I'd love to be involved if possible. I'm (1) very interested and (2) woefully ignorant in this area.
I don't recall if we ever had a formal accessibility review, but we've had ad hoc stuff (e.g., Bug 715877) that led to a reasonable outcome.

Presumably there's been similar ad hoc verification of FxA, simply by virtue of having users reliant on screen readers, but I don't personally know of any. A more formal walkthrough sounds like a good idea.
Flags: needinfo?(rnewman)
Additional ad hoc verification for Android: Bug 974627.
Hi Rimas, in follow-up to your very helpful Bug 974627, are you able to help us audit the Firefox Accounts UI on Android devices?  This would be the UI in Firefox Beta, about to go to release.  I CCed you a dev-fxacct email as well.  Thanks!
Flags: needinfo?(rq)
Note MarcoZ is a key part of our a11y QA and is PTO until Tuesday.
Flags: a11y-review?
(In reply to Nick Alexander :nalexander from comment #6)
> Hi Rimas, in follow-up to your very helpful Bug 974627, are you able to help
> us audit the Firefox Accounts UI on Android devices?  This would be the UI
> in Firefox Beta, about to go to release.  I CCed you a dev-fxacct email as
> well.  Thanks!

Hi Nick, hate to disappoint you, but I'm afraid I have no idea how to test accessibility. I filed the aforementioned bug because I'm a localizer and a web developer, and it itches me each time I have to translate alt-texts like these (which often land on our web pages as well, and usually their meaninglessness is obvious). Sorry, but you'll have to wait for MarcoZ to do the a11y review.
Flags: needinfo?(rq)
(In reply to Rimas Kudelis from comment #8)
> (In reply to Nick Alexander :nalexander from comment #6)
> > Hi Rimas, in follow-up to your very helpful Bug 974627, are you able to help
> > us audit the Firefox Accounts UI on Android devices?  This would be the UI
> > in Firefox Beta, about to go to release.  I CCed you a dev-fxacct email as
> > well.  Thanks!
> 
> Hi Nick, hate to disappoint you, but I'm afraid I have no idea how to test
> accessibility. I filed the aforementioned bug because I'm a localizer and a
> web developer, and it itches me each time I have to translate alt-texts like
> these (which often land on our web pages as well, and usually their
> meaninglessness is obvious). Sorry, but you'll have to wait for MarcoZ to do
> the a11y review.

Hi Rimas, no troubles!  Just trying to connect folks to opportunities.  Thanks for the quick reply, and thanks for localizing Firefox Accounts on Android.
(In reply to Karl Thiessen [:kthiessen] from comment #2)
> :rnewman, do you know what sort of accessibility review Legacy Sync went
> through?  And whether FxA has done anything similar?

No review I'm aware of, but I'm definitely eager to help (and learn) about this process.
Flags: needinfo?(rfeeley)
:marcoZ, have you and your team had any contact/testing with Firefox Accounts and/or New Sync?  Can you point us to a document that tells us how to run an accessibility review for it?
Flags: needinfo?(marco.zehe)
Hi! Sorry for the long delay in replying, I was on PTO this last week.

I did regular testing of Firefox Sync accounts on desktop and mobile, and even found a bug on the desktop where you couldn't activate one of the buttons from the UI with the keyboard. This was fixed immediately, see bug 967479.

On Android, I didn't find any problems, all the fields talked with TalkBack as they should.

The web content surrounding Firefox accounts may need some checking of whether the keyboard focus is always visible, for example. And while re-checking it to give a better reply on this bug, I found that on 
https://accounts.firefox.com/settings
the "About" link has no link text, and screen readers make some funny link out of it from the href source.

A while ago, I collected a hopefully comprehensive, but simple to understand, list of checks one could do from web dev to check for some basic accessibility requirements. The list can be found here:
https://wiki.mozilla.org/Accessibility/WebDev_Recommendations
Flags: needinfo?(marco.zehe)
I tested the sighted keyboard user use case. So far only found one weird bug (not a show stopper since there is a workaround). Filed as bug 1005085.
No longer depends on: 1005085
(In reply to David Bolter [:davidb] from comment #13)
> I tested the sighted keyboard user use case. So far only found one weird bug
> (not a show stopper since there is a workaround). Filed as bug 1005085.

Just noticed the bug applies to "Get Started" as well -- which is more concerning...
Do we think we need more review than this, or anything more formal?  If I don't hear anything back from anyone by end-of-quarter, I'll go ahead and close this.
Not closing as long as we have open dependent bugs.  Thanks for filing bug 1005085, :davidb.

Are there other steps I need to take to get this into triage?
I'm going to '-' the a11y review while we have dependencies and to get it off my bz dashboard. Let's re-request when dependencies are fixed.
Flags: a11y-review? → a11y-review-
Removing myself from QA contact, as I am no longer involved so tightly with FxA.
QA Contact: kthiessen
Priority: -- → P3
Severity: normal → enhancement
Priority: P3 → --

I'm going to close this old bug; from the comments it looks like we did some ad-hoc review and fixed some issues, and I know that we've had occasional accessibility-related issued filed on FxA in the interim.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE

Fair enough. Thanks, Ryan.

You need to log in before you can comment on or make changes to this bug.