996265 - [jsdbg2] ScriptFrameIters stored in Debugger.Frame instances should never be done

Status: NEW

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

The ScriptFrameIter represented by a Debugger.Frame instance should never be '.done()'; we should assert this.

(Marking this as 'blocking' bug 961325, but it's really just 'related'; that could land before this.)

Comment 1

[Jim Blandy :jimb]

Attachment: Assert that iters from Debugger.Frame instances actually refer to something.

Try push:
https://tbpl.mozilla.org/?tree=Try&rev=d4dfe0a8a2d9

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8406461 [details] [diff] [review]
Assert that iters from Debugger.Frame instances actually refer to something.

Review of attachment 8406461 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable, though all this frame munging code frightens me.

Comment 3

[Shu-yu Guo [:shu]]

(In reply to Steve Fink [:sfink] from comment #2)
> Comment on attachment 8406461 [details] [diff] [review]
> Assert that iters from Debugger.Frame instances actually refer to something.
> 
> Review of attachment 8406461 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Seems reasonable, though all this frame munging code frightens me.

In the words of mccr8, welcome to adventure.