996284 - Lock and camera buttons are not available with explore by touch in screen reader

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Eitan Isaacson [:eeejay]]

Bug #985037 was hijacked with another issue. But the issue of the buttons not being available through screen reader explore by touch is still an issue.

STR:
1. Enable screen reader.
2. In lockscreen, notice that putting finger over the clock will highlight and speak it.
3. Put finger over unlock or camera icon.

Result: Nothing happens.
Expected: The icons should highlight and be spoken.

This is due to lockscreen-area being higher in the z-index and swallowing pointer events. I have no simple fix for this since the slider code is pretty complex..

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18459

By raising the z-index we allow gecko layout to find the icons when we do explore by touch. I don't see any adverse effects. But lets see what Travis says, and then lets see what a human reviewer says :)

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8409091 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18459

I remembered there is a zindex issue to prevent me to do that at the very early version of LockScreen slider, however I don't see any wrong with this patch, so a r+ should be granted.

Let's see if we would have any reported issue, and thanks for the fixing.

Comment 3

[Eitan Isaacson [:eeejay]]

https://github.com/eeejay/gaia/commit/4596e5164d1ad314c0d85943ef713278463aab3b