Closed
Bug 996285
Opened 10 years ago
Closed 10 years ago
Profiler stops duplicating samples during sleeping periods after buffer wraps
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: vikstrous, Assigned: vikstrous)
Details
Attachments
(1 file, 1 obsolete file)
1.99 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → vstanchev
Assignee | ||
Comment 1•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=802f440dd5f6
Attachment #8406479 -
Flags: review?(bgirard)
Comment 2•10 years ago
|
||
Comment on attachment 8406479 [details] [diff] [review] profiler_sleeping_bug Review of attachment 8406479 [details] [diff] [review]: ----------------------------------------------------------------- ::: tools/profiler/ProfileEntry.cpp @@ +464,4 @@ > // Scan the whole buffer (even unflushed parts) > // we add mEntrySize to mReadPos to make sure that when > // we wrap around the result is mEntrySize-1 and not -1 > + for (int readPos = (mWritePos + mEntrySize - 1) % mEntrySize; readPos != (mReadPos + mEntrySize - 1) % mEntrySize; readPos = (readPos + mEntrySize - 1) % mEntrySize) { This is getting out of land, you should format as: for (....; ....; ....) {
Attachment #8406479 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Fixed formatting and comments
Attachment #8406479 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(bgirard)
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/408e7a1d91a1
Flags: needinfo?(bgirard)
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/408e7a1d91a1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•