Closed
Bug 996363
Opened 10 years ago
Closed 10 years ago
ShortcutUtils.jsm should order OS X shortcut modifiers correctly
Categories
(Toolkit :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Keywords: polish, ux-consistency)
Attachments
(1 file)
2.77 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
cmd should come after any/all of shift, option and control, not before (when the cloverleaf symbol is used... probably not otherwise?)
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
Has been bugging me for a while now. Consistency with menus is nice. It's a shame we don't have a good way to make the shortcuts line up the same way they do in menus, but I can live with that for now.
Attachment #8406539 -
Flags: review?(bmcbride)
Comment 2•10 years ago
|
||
Comment on attachment 8406539 [details] [diff] [review] order OS X cloverleaf symbol correctly in ShortcutUtils.jsm, Review of attachment 8406539 [details] [diff] [review]: ----------------------------------------------------------------- So... uh..... wanna file a bug to add some tests for this module? :\
Attachment #8406539 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Blair McBride [:Unfocused] from comment #2) > Comment on attachment 8406539 [details] [diff] [review] > order OS X cloverleaf symbol correctly in ShortcutUtils.jsm, > > Review of attachment 8406539 [details] [diff] [review]: > ----------------------------------------------------------------- > > So... uh..... wanna file a bug to add some tests for this module? :\ Filed bug 997128. remote: https://hg.mozilla.org/integration/fx-team/rev/14b25d18dbad
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Updated•10 years ago
|
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/14b25d18dbad
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•