996371 - 7-Zip self-extracting archive fonts are blurry on HiDPI

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Mike Hommey [:glandium]]

Attachment: Screenshot

This is related to bug 961958. See attached screenshot.

Comment 1

[Mike Hommey [:glandium]]

(Ignore the blue outline around the icon, i managed to enable the narrator without knowing when taking the screenshot)

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: updated 7zSD.sfx with dpiAware in the manifest

Tim, this adds the following to the manifest to fix this bug

<application xmlns="urn:schemas-microsoft-com:asm.v3"><windowsSettings>
<dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
</windowsSettings>
</application>

Comment 3

[Robert Strong (they/them - no direct email)]

You can apply the patch to see the changes using resource hacker.

Comment 4

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Out of curiosity, how are you modifying/generating the 7zSD.sfx file?

Comment 5

[Robert Strong (they/them - no direct email)]

I'm updating the in tree 7zSD.sfx file using resource hacker.

When I need to generate a new one I use MSVC6 so the binary will run on older OS's without the dependencies required by newer versions of MSVC. As a side effect MSVC6 also reproduces a smaller binary.

Comment 6

[Robert Strong (they/them - no direct email)]

http://www.angusj.com/resourcehacker/

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 8406587 [details] [diff] [review]
updated 7zSD.sfx with dpiAware in the manifest

Review of attachment 8406587 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry this review took a little while; I'm hesitant to install and run freeware that 1) I can't build from source and 2) is from a publisher that I don't already have to trust.

I happened to have a Win7 VM around so I installed "Resource Hacker" on that and verified that the manifest does now contain the items mentioned in comment 2.

I haven't verified whether that is the only change introduced by this patch; "Resource Hacker" doesn't have a very useful interface for doing that kind of analysis.

Given the current state of privacy on the internet and the fact that we differentiate ourselves by being verifiable [1], it's kind of unfortunate that we have this binary blob in the tree and that the only way to view and modify it is to use third-party closed-source software from a publisher that is not already implicitly trusted. I doubt there's an easy workaround or else we'd already be doing that, but maybe it would be worth filing a bug or adding a readme file explaining why this exists in its current form. I can file the bug if you'd like.

[1] https://brendaneich.com/2014/01/trust-but-verify

Comment 8

[Robert Strong (they/them - no direct email)]

True though I would also say that is true of the closed source tools we use when building as well as packaging. There is no easy workaround and the hard workaround at this time would be to have MSVC6 for our build systems and for repackaging as well in order to get to the state we want. I think the status quo of using the binary which has been the case since Firefox had an installer is the way forward at this time though if you or anyone else can come up with a reasonable way to handle this by all means let's do it.

You can also view the binary diff of the original sfx and the new sfx and see that the changes to the binary file are to say the least minimal to the header of the file along with the manifest changes at the end of the file.

Also, I haven't looked for other resource modification utilities and I wouldn't be surprised if there is an open source one available.

Comment 9

[Robert Strong (they/them - no direct email)]

Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/b2c7cadebd0f

Comment 10

[Mike Hommey [:glandium]]

How much bigger would that file be if it you built it with msvc10 against the static CRT?

Comment 11

[Robert Strong (they/them - no direct email)]

It has been a while since I have done that but iirc it was deemed not worthwhile (e.g. the amount of work required was greater than the return) to do if for no other reason than repackaging would have to be reworked since localizers have a requirement not to compile.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b2c7cadebd0f